Bug #12129
Test suite's --view broken on sid: xtightvncviewer was replaced
100%
Description
It should use xtigervncviewer instead of xtightvncviewer, that’s now a transitional package that ships no binary.
Subtasks
History
#1 Updated by anonym 2017-01-16 12:29:20
tigervnc-viewer
(which is the package I presume you mean) is not available in Jessie (nor jessie-backports
) and our dependency checking does not support “or”, so we have to be a bit more clever than simply switching dependency. I propose we
- in
stable
(etc) keep the dependency onxtightvncviewer
but also support thetigervnc-viewer
binary, if available. - in
feature/stretch
(after merging the above into it) drop everything related toxtightvncviewer
and just depend ontigervnc-viewer
.
That should work, right? And once Tails 3.0 is released, all should be good without further action, so we can just forget about this.
#2 Updated by anonym 2017-01-16 12:38:01
anonym wrote:
> * in feature/stretch
(after merging the above into it) drop everything related to xtightvncviewer
and just depend on tigervnc-viewer
.
Scratch this part — we still want to support testing the feature/stretch
branch on Jessie! So…
> And once Tails 3.0 is released, all should be good without further action, so we can just forget about this.
… instead we file a ticket to do the above bullet’s action when we merge feature/stretch
.
#3 Updated by intrigeri 2017-01-16 12:46:33
>> And once Tails 3.0 is released, all should be good without further action, so we can just forget about this.
> … instead we file a ticket to do the above bullet’s action when we merge feature/stretch
.
This relies on the fact that we’ll stop supporting Jessie for running the test suite at exactly the same time as the feature/stretch merge. I don’t think we’ve ever done this, as it’s not practical for various reasons (e.g. it forces us to upgrade isotesters at exactly that time as well, in lockstep, and I doubt I’ll be able to do that while RM’ing 3.0).
So perhaps instead make this part of Feature #11739 (or even revert it immediately in the topic branch for that ticket, creating it if needed)?
#4 Updated by anonym 2017-01-17 10:10:55
- Status changed from Confirmed to In Progress
Applied in changeset commit:53f485b812a8e80070e84bf0e00c31c2bae9d001.
#5 Updated by anonym 2017-01-17 10:18:58
- Assignee changed from anonym to intrigeri
- % Done changed from 0 to 50
- QA Check set to Ready for QA
- Feature Branch set to test/12129-tigervnc-viewer
Thanks for your input! Please review’n’merge into stable
.
I pushed a branch for Feature #11739 dealing with the follow up vs xtightvncviewer
like you suggested.
#6 Updated by intrigeri 2017-01-17 10:29:09
- Subject changed from Test suite's --view broken on sid: to Test suite's --view broken on sid: xtightvncviewer was replaced
- % Done changed from 50 to 60
Code review passes.
#7 Updated by intrigeri 2017-01-17 10:41:48
- Status changed from In Progress to Fix committed
- % Done changed from 60 to 100
Applied in changeset commit:a95736d7da77fed6f3c1b207e516b3cb2aeb1747.
#8 Updated by intrigeri 2017-01-17 10:52:38
- Assignee deleted (
intrigeri) - QA Check changed from Ready for QA to Pass
#9 Updated by anonym 2017-01-24 20:43:04
- Status changed from Fix committed to Resolved
#10 Updated by intrigeri 2017-01-29 10:52:50
FTR this transition was reverted (https://bugs.debian.org/852855) in sid, so if we have issues with tigervnc we could revert these changes on our side.