Feature #12072
Don't give *Setting objects full access to the greeter object
Start date:
2016-12-23
Due date:
% Done:
0%
Description
tailsgreeter/gui.py AdminSetting.apply()
: the action at a distance on next line is scary; better return the admin password (or False if the check fails), and let the caller modify its own stateā¦ or do some slightly less scary action at a distance? Same comment wrt. the disable method, and more generally it feels wrong that each *Setting objects gets a greeter attribute they can mess with as they want.
The ultimate goal should be to have all controller logic in GreeterApplication
, which could be moved to tailsgreeter
.
Subtasks
History
#1 Updated by intrigeri 2016-12-23 18:23:44
- Subject changed from Don't pass greeter attribute to each setting to Don't give *Setting objects full access to the greeter object
#3 Updated by sajolida 2019-01-22 18:34:42
- Parent task deleted (
)Feature #11643
#4 Updated by intrigeri 2020-04-15 06:02:02
- Affected tool changed from Greeter to Welcome Screen