Bug #11987

ikiwiki includes "Posted" timestamps in some generated web pages

Added by intrigeri 2016-11-22 08:07:01 . Updated 2017-03-13 12:46:31 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Build system
Target version:
Start date:
2016-11-22
Due date:
% Done:

100%

Feature Branch:
451f:tails/feature/11987+remove_ikiwiki_timestamps
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:
289

Description

We’ve seen that break reproducibility once. Looks like they come from templates/archivepage.tmpl and/or templates/inlinepage.tmpl.

It might have been fixed by commit:541bbe5fd3c1127232ce271041f9dddb94e3f5d7 when one uses cleanall, but this remains to be verified.

Subtasks

Related issues

Related to Tails - Feature #11966: Reproducible website build Resolved 2016-11-19

History

#1 Updated by intrigeri 2016-11-22 08:07:57

#2 Updated by Anonymous 2017-03-13 09:24:26

  • Assignee deleted (intrigeri)

#3 Updated by Anonymous 2017-03-13 10:30:49

After verification using a recent build, these timestamps are still present.
We will need to modify the page templates in our wiki and/or report this upstream (however i doubt that this will be accepted as an upstream modification).

#4 Updated by Anonymous 2017-03-13 11:14:31

  • Feature Branch set to 451f:tails/feature/11987+remove_ikiwiki_timestamps

#5 Updated by Anonymous 2017-03-13 11:15:38

I’ve built the wiki locally and this seems to work now. The only left “timestamp” is the one concerning the latest release in the sidebar.

#6 Updated by Anonymous 2017-03-13 11:25:15

  • Assignee set to intrigeri
  • % Done changed from 0 to 40
  • QA Check set to Ready for QA

#7 Updated by intrigeri 2017-03-13 11:39:46

  • Status changed from Confirmed to In Progress

#8 Updated by intrigeri 2017-03-13 11:45:33

  • % Done changed from 40 to 50

Looks good! Code review passes. I would have preferred 2 commits (one that imports the upstream files, and one that modifies them) so it’s easier to maintain our delta in the future, but our custom changes seem simple enough so I won’t block on it. Will test locally and merge if it works for me! :)

#9 Updated by Anonymous 2017-03-13 11:52:30

  • % Done changed from 50 to 40

intrigeri wrote:
> Looks good! Code review passes. I would have preferred 2 commits (one that imports the upstream files, and one that modifies them) so it’s easier to maintain our delta in the future, but our custom changes seem simple enough so I won’t block on it. Will test locally and merge if it works for me! :)

ack. One can also just do a diff with the files in /usr/share/ikiwiki/templates.

#10 Updated by intrigeri 2017-03-13 12:45:46

  • Status changed from In Progress to Resolved
  • % Done changed from 40 to 100

Applied in changeset commit:105836f401678cc7465029e57a7417e669672342.

#11 Updated by intrigeri 2017-03-13 12:46:31

  • Assignee deleted (intrigeri)
  • QA Check changed from Ready for QA to Pass