Bug #11986

Generated APT auto-removal config file encodes the build system's kernel version

Added by intrigeri 2016-11-22 08:04:56 . Updated 2017-03-14 06:38:44 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Build system
Target version:
Start date:
2016-11-22
Due date:
% Done:

100%

Feature Branch:
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:
289

Description

… which breaks reproducibility.


Subtasks


History

#1 Updated by lamby 2017-03-13 09:32:09

  • Assignee changed from intrigeri to lamby

#3 Updated by intrigeri 2017-03-13 17:50:57

  • Assignee changed from lamby to anonym
  • QA Check set to Info Needed

> Should be fixed in https://anonscm.debian.org/cgit/apt/apt.git/commit/?id=a9b56a0

Yeah! Looks like we could apply this as a local patch against /etc/kernel/postinst.d/apt-auto-removal in our Git tree, until this change makes it into Stretch. Or… simply replace the content of this file with a trivial no-op, since it’s not super useful in Tails anyway. anonym, what do you think?

#4 Updated by anonym 2017-03-13 18:30:58

  • Assignee changed from anonym to intrigeri
  • QA Check changed from Info Needed to Dev Needed

intrigeri wrote:
> > Should be fixed in https://anonscm.debian.org/cgit/apt/apt.git/commit/?id=a9b56a0
>
> Yeah! Looks like we could apply this as a local patch against /etc/kernel/postinst.d/apt-auto-removal in our Git tree, until this change makes it into Stretch. Or… simply replace the content of this file with a trivial no-op, since it’s not super useful in Tails anyway. anonym, what do you think?

I prefer that we patch /etc/kernel/postinst.d/apt-auto-removal: once we get an apt with lamby’s fix we’ll get a build error as a notification that we can remove this workaround; the other solution will not generate such a notification, and we’ll keep that code indefinitely. Less [code] is more!

#5 Updated by intrigeri 2017-03-13 21:54:48

  • Status changed from Confirmed to In Progress
  • Assignee changed from intrigeri to anonym
  • % Done changed from 0 to 20
  • QA Check changed from Dev Needed to Info Needed

anonym wrote:
> I prefer that we patch /etc/kernel/postinst.d/apt-auto-removal:

So I did this but that’s not enough: by the time our patches are applied, the differing file has already been generated. So, either we look into it further (probably means manually re-running some script ourselves late, which adds clever code that needs to be maintained), or we go with the other option I’ve proposed, that will take less, and less clever code (#!bin/sh\n/bin/true is pretty easy to maintain).

#6 Updated by intrigeri 2017-03-14 05:19:33

  • Assignee changed from anonym to intrigeri
  • QA Check changed from Info Needed to Dev Needed

intrigeri wrote:
> […] or we go with the other option I’ve proposed,

Wait, I was confused. That other option will have exactly the same problem.

#7 Updated by intrigeri 2017-03-14 06:38:44

  • Status changed from In Progress to Resolved
  • Assignee deleted (intrigeri)
  • % Done changed from 20 to 100
  • QA Check deleted (Dev Needed)