Feature #11953

Implement "Relock Persistent Storage" correctly

Added by sajolida 2016-11-17 20:22:54 . Updated 2020-04-15 06:02:02 .

Status:
Confirmed
Priority:
Normal
Assignee:
alant
Category:
Target version:
Start date:
2016-11-17
Due date:
% Done:

0%

Feature Branch:
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Welcome Screen
Deliverable for:

Description

  1. Unlock the persistent storage.
  2. Click the “Relock Persistent Storage” button.
  3. It fails to relock.

Subtasks

History

#1 Updated by intrigeri 2016-12-21 10:42:29

  • This should be implemented using the close_volumes() function that’s in config/chroot_local-includes/usr/local/sbin/live-persist, so that we have only one implementation of this thing.
  • I’m not 100% convinced that we should commit to support this functionality on the long run. Some stuff we do when activating a persistent volume can’t be reverted already; it’s no big deal but we might have to add more such stuff, and then the resulting UX will be “when I unlock then relock my persistence storage, its content has changed”, which may not match their expectations. Was this taken into account when deciding to add this feature?

#2 Updated by intrigeri 2016-12-21 10:56:13

intrigeri wrote:
> * I’m not 100% convinced that we should commit to support this functionality on the long run. Some stuff we do when activating a persistent volume can’t be reverted already; it’s no big deal but we might have to add more such stuff, and then the resulting UX will be “when I unlock then relock my persistence storage, its content has changed”, which may not match their expectations. Was this taken into account when deciding to add this feature?

One idea to workaround this is to only unlock the LUKS volume in the Greeter, and postpone live-persist activate to PostLogin, so that we can really revert to the initial state of things with a “Lock” button. Now, this prevents us from ever displaying potential live-persist activate errors in the Greeter, but well, I guess that’s acceptable.

#3 Updated by intrigeri 2016-12-21 11:02:11

I’d rather not block on this for integrating the new Greeter into Tails 3.0~beta1: doing it properly in a way that hasn’t at least as bad UX drawbacks as the advantages it’s meant to give us requires quite some work, let’s focus on polishing the code that’s almost ready for now, and then we’ll iterate.

#4 Updated by alant 2016-12-21 15:44:45

  • Subject changed from "Relock Persistent Storage" doesn't work in new Greeter to Implement "Relock Persistent Storage" correctly

See Feature #12058 for hiding the feature in the beta.

#5 Updated by sajolida 2019-01-22 18:36:09

#6 Updated by intrigeri 2020-04-15 06:02:02

  • Affected tool changed from Greeter to Welcome Screen