Feature #11936
OpenPGP applet GNOME Shell extension: dynamically update the icon & menu depending on the content of the clipboard
50%
Description
Files
Subtasks
Related issues
Blocked by Tails - Feature #11934: Have org.Tails.OpenPGPApplet send signals when the type of what's in the clipboard changes | Confirmed | 2016-11-16 |
History
#1 Updated by intrigeri 2016-11-16 15:16:43
- blocked by Feature #11934: Have org.Tails.OpenPGPApplet send signals when the type of what's in the clipboard changes added
#2 Updated by alant 2016-11-17 00:40:11
- File testDBusService.py added
- Assignee changed from alant to intrigeri
- % Done changed from 0 to 50
- QA Check set to Ready for QA
There is a working implementation in alan/openpgp-applet:feature/8310-gnome-shell
. It is waiting for the service to send the ClipboardContentChanged
signal with a single boolean is_encrypted
parameter.
Find attached a dummy service for testing purpose. To send ClipboardContentChanged (True)
:
dbus-send --print-reply --type=method_call --dest=org.Tails.OpenPGPApplet /org/Tails/OpenPGPApplet org.Tails.OpenPGPApplet.EmitTrue
To send ClipboardContentChanged (False)
:
dbus-send --print-reply --type=method_call --dest=org.Tails.OpenPGPApplet /org/Tails/OpenPGPApplet org.Tails.OpenPGPApplet.EmitFalse
#3 Updated by intrigeri 2016-11-17 08:01:13
- Status changed from Confirmed to In Progress
#4 Updated by intrigeri 2017-01-30 18:14:29
- Assignee changed from intrigeri to alant
- QA Check changed from Ready for QA to Dev Needed
alant wrote:
> There is a working implementation in alan/openpgp-applet:feature/8310-gnome-shell
. It is waiting for the service to send the ClipboardContentChanged
signal with a single boolean is_encrypted
parameter.
Great, thanks! Sadly, this interface is a bit too simplistic, as there are more than two types of content in the clipboard (and corresponding icon indicators): we have none (empty clipboard), encrypted, signed, and (plain)text. The package also ships an icon for when a key is detected in the clipboard, but AFAIK it’s not used yet. So I suggest we pass a string argument to the signal, and let’s use the same values that are already used elsewhere in the code: “message” (== encrypted), “none”, “signed”, and “text” (plaintext).
Sorry I didn’t specify this better initially!
#5 Updated by intrigeri 2017-01-30 19:13:02
- blocks deleted (
Feature #11934: Have org.Tails.OpenPGPApplet send signals when the type of what's in the clipboard changes)
#6 Updated by alant 2017-01-30 22:18:36
- Assignee changed from alant to intrigeri
> Great, thanks! Sadly, this interface is a bit too simplistic, as there are more than two types of content in the clipboard (and corresponding icon indicators): we have none (empty clipboard), encrypted, signed, and (plain)text. The package also ships an icon for when a key is detected in the clipboard, but AFAIK it’s not used yet. So I suggest we pass a string argument to the signal, and let’s use the same values that are already used elsewhere in the code: “message” (== encrypted), “none”, “signed”, and “text” (plaintext).
>
Looks good, tell me when it is implemented on your side.
#7 Updated by intrigeri 2017-01-31 08:49:33
- blocked by Feature #11934: Have org.Tails.OpenPGPApplet send signals when the type of what's in the clipboard changes added
#8 Updated by intrigeri 2017-01-31 08:50:35
- Assignee changed from intrigeri to alant
- QA Check deleted (
Dev Needed)
alant wrote:
> Looks good, tell me when it is implemented on your side.
Sure. Re-added the blocking dependency then.
#9 Updated by intrigeri 2017-05-20 06:31:47
- Target version changed from Tails_3.0 to Tails_3.2
#10 Updated by intrigeri 2017-09-15 18:23:44
- Target version deleted (
Tails_3.2)
#11 Updated by nodens 2018-02-25 18:26:10
Not duplicating this issue upstream, since the work referenced here doesn’t exist on upstream repository at https://salsa.debian.org/openpgp-applet-team/openpgp-applet/.
Feel free to create an issue and create a branch or refer to the current work somehow there ;)
#12 Updated by intrigeri 2019-03-23 17:39:06
- Assignee deleted (
alant)