Feature #11929

Upstream AppArmor profiles for Onionshare

Added by Anonymous 2016-11-16 12:51:41 . Updated 2019-02-16 06:32:08 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Target version:
Tails_2.11
Start date:
2016-11-16
Due date:
% Done:

10%

Feature Branch:
Type of work:
Communicate
Blueprint:

Starter:
Affected tool:
OnionShare
Deliverable for:

Description

See https://labs.riseup.net/code/issues/7870#note-76

Subtasks

Related issues

Related to Tails - Bug #14649: Ship OnionShare 2.x in Tails Confirmed 2017-09-13
Blocked by Tails - Feature #11930: Review AppArmor profiles for OnionShare Resolved 2016-11-16

History

#1 Updated by Anonymous 2016-11-16 12:52:59

  • Subject changed from Upstream apparmor profiles for onionshare to Upstream apparmor profiles for Onionshare
  • Target version set to 284

#2 Updated by Anonymous 2016-11-19 13:05:20

https://git-tails.immerda.ch/tails/tree/config/chroot_local-includes/etc/apparmor.d?h=feature/7870-include_onionshare The profile for onioncircuits should not belong into this branch IMO.

#3 Updated by Anonymous 2016-11-19 20:36:07

  • % Done changed from 0 to 10

Created a pull request upstream: https://github.com/micahflee/onionshare/pull/320

#4 Updated by anonym 2016-11-25 10:56:51

  • Target version changed from 284 to Tails 2.10

#5 Updated by intrigeri 2016-12-06 16:13:49

  • Subject changed from Upstream apparmor profiles for Onionshare to Upstream AppArmor profiles for Onionshare

#6 Updated by intrigeri 2016-12-07 09:17:41

This is not a blocker for Feature #7870.

#7 Updated by intrigeri 2016-12-07 09:17:57

  • blocked by Feature #11930: Review AppArmor profiles for OnionShare added

#8 Updated by intrigeri 2016-12-07 09:18:49

intrigeri wrote:
> This is not a blocker for Feature #7870

… so feel free to move this to a later target version.

#9 Updated by intrigeri 2016-12-07 09:21:16

  • Affected tool set to OnionShare

#10 Updated by intrigeri 2016-12-07 09:21:48

  • Tracker changed from Bug to Feature
  • Status changed from Confirmed to In Progress

#11 Updated by intrigeri 2016-12-07 09:24:13

u wrote:
> Created a pull request upstream: https://github.com/micahflee/onionshare/pull/320

I think we should wait for Feature #11930 to be done first. And anonym wrote on Feature #7870 that his profiles break functionality if enforced, so it sounds like more initial work may be needed to upstream them. If you agree, I’ll let you tell Micah Lee that he shouldn’t merge this branch as-is. Sorry if I missed something :)

#12 Updated by Anonymous 2017-01-17 15:26:46

Those things need to be upstreamed:

6e7ad41ca9 Remove superfluous AppArmor rule.
b3a827d8e3 Make onionshare-gui able to access folders beneath $HOME.

#13 Updated by Anonymous 2017-01-18 20:03:20

Here is a pull request for the latest improvements : https://github.com/micahflee/onionshare/pull/348

#14 Updated by Anonymous 2017-01-18 20:03:48

  • Target version changed from Tails 2.10 to Tails_2.11

#15 Updated by Anonymous 2017-01-23 20:55:27

  • Status changed from In Progress to Fix committed
  • Assignee deleted ()

This was merged, yay.

As soon as there will be a new release I will add it to the Debian package. Also considering adding it as a patch eventually.

#16 Updated by intrigeri 2017-01-24 10:01:41

Congrats!

#17 Updated by anonym 2017-03-09 13:59:04

  • Status changed from Fix committed to Resolved

#18 Updated by intrigeri 2019-02-05 11:59:17

  • related to Bug #16414: onionshare-gui does not start in VirtualBox (with VBoxVGA and 3D acceration enabled) added

#19 Updated by intrigeri 2019-02-16 06:31:44

  • related to Bug #14649: Ship OnionShare 2.x in Tails added

#20 Updated by intrigeri 2019-02-16 06:32:08

u wrote:
> As soon as there will be a new release I will add it to the Debian package.

FTR this is now tracked on Bug #14649.

#21 Updated by intrigeri 2019-02-16 06:32:23

  • related to deleted (Bug #16414: onionshare-gui does not start in VirtualBox (with VBoxVGA and 3D acceration enabled))