Bug #11913

Switch default search engine to DuckDuckGo

Added by bertagaz 2016-11-15 08:49:04 . Updated 2016-12-14 20:10:50 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Internationalization
Target version:
Tails_2.9.1
Start date:
2016-11-15
Due date:
% Done:

100%

Feature Branch:
feature/11913-ddg-as-default-in-tor-browser
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Browser
Deliverable for:

Description

Upstream Tor Browser has done that, since disconnect.me keeps on redirecting to duckduckgo and users are annoyed/scared by that. We should switch our localization extension to use duckduckgo too.

Subtasks

Related issues

Has duplicate Tails - Bug #11845: Replace defunct search engines in torbrowser Duplicate 2016-09-26

History

#1 Updated by bertagaz 2016-11-15 10:37:00

  • Affected tool set to Browser

Note that this also means reverting commit:6d9e5eaf68b8a0ab1708eee9e9bf41858a19e8de

#2 Updated by elouann 2016-11-21 11:45:42

  • has duplicate Bug #11845: Replace defunct search engines in torbrowser added

#3 Updated by anonym 2016-12-09 13:33:06

  • % Done changed from 0 to 30
  • Feature Branch set to feature/11913-ddg-as-default-in-tor-browser

The current branch switches to DDG, but it’s not localized.

#4 Updated by anonym 2016-12-09 15:55:29

  • Status changed from Confirmed to In Progress

Applied in changeset commit:8e6d5bc602195d921596dfa66ebf2b2fc1f422b1.

#5 Updated by anonym 2016-12-10 15:19:23

  • Assignee changed from anonym to intrigeri
  • % Done changed from 30 to 50
  • QA Check set to Ready for QA

Now we localize (the UI only) for DDG. This branch also sneaks in a few other search plugin-related changes, in particular that “unwanted” plugins also are purged from the langpacks — apparently they were introduced there some time ago, and since then only English locales have had the cured set of search engines. Whoops!

intrigeri, will you review’n’merge?

#6 Updated by intrigeri 2016-12-10 16:17:19

> intrigeri, will you review’n’merge?

I can make some room for urgent stuff tomorrow if needed, but generally it’s too late for me to review 2.9 stuff.

#7 Updated by intrigeri 2016-12-10 16:17:57

  • Assignee changed from intrigeri to anonym

(Reassigning to anonym so he gets a chance to find another reviewer if my own availability is not good enough.)

#8 Updated by intrigeri 2016-12-11 08:38:29

  • Assignee changed from anonym to intrigeri

I’ll try to do it.

#9 Updated by intrigeri 2016-12-11 08:45:27

  • Subject changed from Switch default search engine to duckduckgo to Switch default search engine to DuckDuckGo

#10 Updated by intrigeri 2016-12-11 08:59:36

  • % Done changed from 50 to 60

Code review passes.

#11 Updated by intrigeri 2016-12-11 10:16:29

  • Assignee changed from intrigeri to anonym

Is it on purpose that when logging in with a non-English locale, one gets only the localized DDG? If yes, feel free to merge after running the affected automated tests (I didn’t do this and I think that Jenkins doesn’t either). If not, merge as well but file a ticket about it :)

#12 Updated by anonym 2016-12-11 11:53:16

intrigeri wrote:
> Is it on purpose that when logging in with a non-English locale, one gets only the localized DDG?

Yes — only the UI is localized, not search results, which I think is fine.

> If yes, feel free to merge after running the affected automated tests (I didn’t do this and I think that Jenkins doesn’t either).

Ack, thanks!

#13 Updated by anonym 2016-12-11 17:20:35

  • Status changed from In Progress to Fix committed
  • Assignee deleted (anonym)
  • % Done changed from 60 to 100
  • QA Check changed from Ready for QA to Pass

intrigeri also reviewed the two extra commits (commit:772c081 and commit:57fd3b3) I had to push. Merged!

#14 Updated by anonym 2016-12-14 20:10:50

  • Status changed from Fix committed to Resolved