Bug #11796

DAVE downloads don't show up in download lists in Firefox >45

Added by Anonymous 2016-09-15 01:50:26 . Updated 2017-12-16 07:37:06 .

Status:
Resolved
Priority:
Normal
Assignee:
ma1
Category:
Target version:
Tails_2.7
Start date:
2016-09-15
Due date:
% Done:

100%

Feature Branch:
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

Since FF 45 the downloads of Tails ISO images made with DAVE don’t show up anymore in the download list.

Assigning this to ma1, so that we don’t loose track of it.

Files

bug11796.patch (756 B) ma1, 2016-10-05 17:47:50

Subtasks

History

#1 Updated by ma1 2016-10-05 17:53:29

  • File bug11796.patch added
  • % Done changed from 0 to 90
  • QA Check set to Info Needed

It turns out Firefox 45 started to be stricter about download visibility depending of their private browsing attributes, and since we create all the downloads as private, they are never shown anywhere.

I’m attaching a patch which fixes this: now downloads added from private windows are visible in the same window’s download manager UI only, and download added from a public window are visible in all the public ones.

Do you want me to commit and push this anywhere, or would it be better for u to merge it?

#2 Updated by sajolida 2016-10-06 18:02:13

  • Subject changed from DAVE needs an update in order to work with Firefox >45 to DAVE downloads don't show up in download lists in Firefox >45
  • Assignee deleted (ma1)
  • QA Check changed from Info Needed to Ready for QA

It would be good if u reviews this and make sure it fixes the ticket that she opened.

#3 Updated by intrigeri 2016-10-07 17:07:30

Regarding how to prioritize this task: this doesn’t break anything in practice, since we display the download progress in the web page’s body, right? Or does it affect resuming interrupted downloads somehow?

#4 Updated by ma1 2016-10-24 11:00:33

It might affect resuming across sessions or in different tabs with different “private” status.
Resuming in the same tab should work anyway, but feedback in the download manager is definitely handy, I think.

#5 Updated by Anonymous 2016-10-27 08:48:45

  • Status changed from Confirmed to Resolved
  • Assignee deleted ()
  • % Done changed from 90 to 100
  • QA Check changed from Ready for QA to Pass

Dear ma1

thank you very much!

This fixes the problem.

And it feels much better to give the user the visual feedback they’re used to when downloading something.

#6 Updated by intrigeri 2016-10-27 09:21:33

  • Status changed from Resolved to Fix committed
  • Assignee set to ma1
  • Target version set to Tails_2.7

(Let’s mark as resolved only once a fix has actually been released to users. Reassigning to ma1 who’ll presumably do the release.)

#7 Updated by Anonymous 2016-10-27 09:37:32

So indeed, when I resume from a different browser session, my previous download is still in the download list but the AddOn does not detect that and instead starts a new download.
But resuming in the same session, even through different tabs works as expected.

#8 Updated by bertagaz 2016-11-15 18:23:33

  • Status changed from Fix committed to Resolved

#9 Updated by intrigeri 2017-12-16 07:37:06

  • Affected tool deleted (Download and Verification Extension)