Tails

#1 Updated by anonym 2016-06-14 11:21:56

• Status changed from Confirmed to In Progress
• Assignee deleted (anonym)
• % Done changed from 0 to 60
• QA Check set to Ready for QA

Given this crappy situation, I just built and uploaded 45.1.0-1~deb8u1+tails1. u, can you check that what I did in the tails/jessie branch in the icedove Git repo makes sense (as an after-the-fact review)?

This passed the full manual test suite, and solves Bug #11486 and should improve Bug #10933.

#2 Updated by Anonymous 2016-06-15 03:04:42

• Assignee set to anonym

Hi!

What you did looks fine.

One thing I noticed, which is different from the previous version:

 --- a/mailnews/base/prefs/content/accountcreation/fetchhttp.js
 +++ b/mailnews/base/prefs/content/accountcreation/fetchhttp.js
 @@ -96,6 +96,13 @@ FetchHTTP.prototype =
@@ -44,7 +44,7 @@ index 5f0cc70..436ac37 100644
 +
      for (var name in this._urlArgs)
      {
-       url += (!url.contains("?") ? "?" : "&") +
+       url += (!url.includes("?") ? "?" : "&") +

Is that expected?

In order to build normally, I had to modify debian/gbp.conf to use our tails/jessie branch, instead of Debian’s jessie-security branch.

I’ll push that to our main repo now.

#3 Updated by anonym 2016-06-15 03:32:51

• Assignee deleted (anonym)
• % Done changed from 60 to 80

u wrote:
> Hi!
>
> What you did looks fine.

Yay!

> One thing I noticed, which is different from the previous version:
> […]
> Is that expected?

It’s a change from Mozilla upstream, one among many affecting the same files as our patches, so it is expected, see:

git log -p upstream/38.8.0..origin/tails/jessie -- mailnews/base/prefs/content/accountcreation/

> In order to build normally, I had to modify debian/gbp.conf to use our tails/jessie branch, instead of Debian’s jessie-security branch.

I’ve been cheating with gbp buildpackage --git-ignore-branch. :)

> I’ll push that to our main repo now.

Thanks for a proper solution!

Please close this ticket if you are happy with all this now.

#4 Updated by Anonymous 2016-06-15 03:36:35

• Status changed from In Progress to Resolved
• Assignee deleted ()
• % Done changed from 80 to 100
• QA Check deleted (Ready for QA)

perfect. thanks!

#5 Updated by anonym 2016-06-15 05:08:11

• Status changed from Resolved to Fix committed
• QA Check set to Pass

#7 Updated by intrigeri 2016-07-31 10:27:53

• Parent task set to Feature #5663
• Deliverable for set to 268

#8 Updated by intrigeri 2016-08-02 09:29:46

• Status changed from Fix committed to Resolved