Bug #11386
Test suite: undefined local variable or method `force_new_tor_circuit'
100%
Description
I see that:
Scenario: whois(1) should work and go through Tor. # features/torified_misc.feature:21
When I query the whois directory service for "torproject.org" # features/step_definitions/torified_misc.rb:1
undefined local variable or method `force_new_tor_circuit' for #<Object:0x0000000384afc8> (NameError)
./features/support/helpers/misc_helpers.rb:99:in `block in retry_tor'
./features/support/helpers/misc_helpers.rb:128:in `call'
./features/support/helpers/misc_helpers.rb:128:in `rescue in block in retry_action'
./features/support/helpers/misc_helpers.rb:120:in `block in retry_action'
./features/support/helpers/misc_helpers.rb:119:in `loop'
./features/support/helpers/misc_helpers.rb:119:in `retry_action'
./features/support/helpers/misc_helpers.rb:103:in `retry_tor'
./features/step_definitions/torified_misc.rb:2:in `/^I query the whois directory service for "([^"]+)"$/'
features/torified_misc.feature:22:in `When I query the whois directory service for "torproject.org"'
Apparently commit:5dae96819691556a120400609616439d4cd83d91 removed force_new_tor_circuit
, but either it was still used elsewhere, or there was a race with the merge of another branch that relied on it.
Subtasks
History
#1 Updated by anonym 2016-04-29 05:05:45
Yeah, I noticed this while working on Feature #9521 so its branch contains a fix in commit:a0103997c5c81686a68447a9846df5c3777c0230.
#2 Updated by intrigeri 2016-04-29 07:30:19
> Yeah, I noticed this while working on Feature #9521 so its branch contains a fix in commit:a0103997c5c81686a68447a9846df5c3777c0230.
OK. I’m fine with blocking on Feature #9521 to get this fix, but a quick review’n’merge to get this into 2.4 (in case Feature #9521 doesn’t) would be doable.
#3 Updated by intrigeri 2016-05-05 09:28:29
Note that I’m hitting this quite regularly these days, and thus have to re-run tests by hand.
#4 Updated by anonym 2016-06-02 14:40:32
- Status changed from Confirmed to Fix committed
- Assignee deleted (
anonym) - % Done changed from 0 to 100
- QA Check set to Pass
This was committed a while ago, when Feature #9521’s topic branch was merged.
#5 Updated by anonym 2016-06-08 01:26:30
- Status changed from Fix committed to Resolved