Tails

#5 Updated by intrigeri 2016-09-30 05:10:43

> intrigeri: do you mind trading the review that you offered me for Thursday on Feature #10176 with this one :)

Sure. “Code” review passes, modulo a few non-blocking comments:

• In “You downloaded Tails for free”, I think that “You have downloaded” would be more correct (but I may be wrong of course).
• I would drop “And” in “And we want to keep it this way”. YMMV.
• “If everybody using Tails today donated […]” feels a bit weird as-is: without making it clear how much each of them would need to donate for that to work, this sentence conveys no information at all, at least for people like me, since it can always be made true with one single huge donor. Now, likely most people who will read that are not like me in this respect, so feel free to ignore this comment :)
• JFTR I feel uneasy reviewing CSS code, since I’m a total newbie in this area. So (in general and ideally) it would be nice to have such bits reviewed by actual web developers. Now, I totally understand that we are short on web developers, and that our web developers may be busy with other things currently. No big deal.

I’ll now build and test this.

#7 Updated by spriver 2016-09-30 15:07:42

I took a quick look at it, I like the new changes.
However (additional to intrigeri’s proposes):
-Maybe it’s just me, but the banner on /home.html feels a bit glued to the latest news. I think a bit of space (e.g. the about the same length of the “Donate” button) between the banner and the news part would make it a bit more tidy. The news items itself also have some space between them. (or maybe we could drop all news from /home for the duration of the donation campaign and have a link below the banner pointing to /news )

-The title of the website says “Dear Tails users,”. This feels a bit strange for me, IMHO we could use another title for the page itself (however, I like the “Dear Tails users,” above the banners’ box) or maybe say “Dear Tails user” since it’s a bit more personal.

Just my little nitpicking (: I could not find any quick solution for TMPL_VAR BASEURL since I don’t have the time for that right now.

#8 Updated by sajolida 2016-10-03 00:30:15

> * In “You downloaded Tails for free”, I think that “You have downloaded” would be more correct (but I may be wrong of course).

I think that both are correct, Microsoft uses the preterite in different
places, and it’s shorter so I’ll keep it this way:

https://www.microsoft.com/en-us/software-download/windows10 (under
“Additional methods for using the ISO file”): “If you downloaded an ISO
file for Windows 10…”.

> * I would drop “And” in “And we want to keep it this way”. YMMV.

I like the “And” as it brings in more emphasis and rythm.

> * “If everybody using Tails today donated […]” feels a bit weird as-is: without making it clear how much each of them would need to donate for that to work, this sentence conveys no information at all, at least for people like me, since it can always be made true with one single huge donor. Now, likely most people who will read that are not like me in this respect, so feel free to ignore this comment :)

I fixed that in 2d79151.

I initially didn’t put an amount, because I thought that “12€” was a
good average donation amount and as such didn’t need to be mentioned
(and avoided having to choose between putting it in euros or dollars).
But now I added it to the draft blog post and it doesn’t take much spare
here either so you made me change my mind.

> * JFTR I feel uneasy reviewing CSS code, since I’m a total newbie in this area. So (in general and ideally) it would be nice to have such bits reviewed by actual web developers. Now, I totally understand that we are short on web developers, and that our web developers may be busy with other things currently. No big deal.

I know! :(

> The link in the yellow header is broken on my build

Woh, this was a big bug! I went too fast copy the code from
templates/pages.html to sidebar.mdwn. It’s fixed now in 6b3dde1.

#9 Updated by sajolida 2016-10-03 01:21:51

> -Maybe it’s just me, but the banner on /home.html feels a bit glued to the latest news.

I made the whole thing quite compact because we will publish news that
go along the donation campaign during it, so I wanted people landing on
/home to be able to see the title of the first post without scrolling.
But I understand your concern and now use the same margin that we have
on top, between the page title and the banner. It’s not much, but is it
better like this?

> Maybe we could drop all news from /home for the duration of the
donation campaign and have a link below the banner pointing to /news)

See my previous comment: I want people starting Tails to see the first
post, and be able to read it if they scroll.

> -The title of the website says “Dear Tails users,”. This feels a bit strange for me, IMHO we could use another title for the page itself (however, I like the “Dear Tails users,” above the banners’ box) or maybe say “Dear Tails user” since it’s a bit more personal.

Right, so that’s two things:

- Say “user” instead of “users” and I’m all for it. Done in fcfe44a.
- Putting something different at the

of the page. That’s
complicated in ikiwiki and I think we shouldn’t bother for now… Still,
I’m removing the comma with d20a19e because it looks ugly in the
titlebar of the browser.