Bug #11268
"Download again" link doesn't download again
0%
Description
At least on https://tails.boum.org/install/download/?small, after the download is finished, if I click on “Download again”, the page is reloaded but in the same state.
Subtasks
History
#1 Updated by sajolida 2016-03-21 00:27:04
- blocks #8538 added
#2 Updated by sajolida 2016-03-21 00:27:23
- Subject changed from "Download again" linke doesn't download again to "Download again" link doesn't download again
#3 Updated by tchou 2016-08-18 02:25:04
- Assignee changed from tchou to sajolida
- QA Check set to Ready for QA
- Feature Branch set to web/11268-really-download-again
I did not succed using the extension localy.
I thing that a test mode has been removed, but it’s maybe also because my setup changed.
This commit probably will work.
#4 Updated by sajolida 2016-08-30 07:18:58
- Assignee changed from sajolida to tchou
- QA Check changed from Ready for QA to Dev Needed
I still get the same result.
- Download the ISO image
- Click “Download again”
- The page gets reloaded in the same state (3. Verify ISO image)
#5 Updated by tchou 2016-09-12 06:52:49
- Assignee changed from tchou to sajolida
- QA Check changed from Dev Needed to Ready for QA
In my last commit I turned the “download-again” #id to a .class.
Maybe that would help.
I’ve read the dave js code, and #download-button-state-cancel seems the good id.
Could you push again ? (I really to know how to test this code)
#6 Updated by sajolida 2016-09-12 12:35:12
- Assignee changed from sajolida to tchou
Ok, I merged and pushed it again (without testing). You can test it like I did last time by download an ISO image and try to click “Download again” after that.
#7 Updated by tchou 2016-09-13 03:01:53
- Assignee changed from tchou to sajolida
- QA Check changed from Ready for QA to Info Needed
It seems to “work” (it’s possible to download again), but I don’t think it’s what we want:
1 - it display step 1 as done
2 - it display download as activable
3 - it display the verify section message
We could be ok with 1 and 2 as it is, but there is still the verify section message.
I tried to change it, but verify messages are not children of data-state so it some not doable with css.
Plus: I think that it would be better to go back on the first step: choose the download method, so the user can use torrent if there it’s too slow for exemple.
If we agree on that, maone will have to change the extension behavior.
#8 Updated by sajolida 2016-09-25 11:17:22
- Assignee changed from sajolida to tchou
Ok, thanks for testing and I agree with your reasoning and going back to step 1 makes more sense. Then please clarify to Giorgio what needs to be done as reassign this to him.
#9 Updated by tchou 2016-10-31 05:03:02
- Assignee changed from tchou to ma1
Hey Giorgio,
Could you change to behavior of the “Download again” button ?
It would be better to come back to the step 1 : I can choose between torrent and DAVE.
Let me know if you need any precisions.
#10 Updated by ma1 2016-11-03 16:37:49
- Assignee changed from ma1 to sajolida
- QA Check changed from Info Needed to Ready for QA
Including it in the upcoming 2.8 AMO release.
#11 Updated by sajolida 2016-11-06 20:07:45
- Status changed from Confirmed to Resolved
- Assignee deleted (
sajolida) - QA Check deleted (
Ready for QA)
It works, cool!