Feature #11243

Update screenshots of OpenPGP Applet to Jessie

Added by sajolida 2016-03-16 10:01:44 . Updated 2016-11-26 16:42:06 .

Status:
Resolved
Priority:
Low
Assignee:
Category:
Target version:
Start date:
2016-03-16
Due date:
% Done:

0%

Feature Branch:
spriver:feature/11243-OpenPGP-Applet-screenshots
Type of work:
End-user documentation
Blueprint:

Starter:
Affected tool:
OpenPGP Applet
Deliverable for:

Description

  • wiki/src/doc/encryption_and_privacy/gpgapplet/gpgapplet_with_padlock.png
  • wiki/src/doc/encryption_and_privacy/gpgapplet/gpgapplet_with_seal.png
  • wiki/src/doc/encryption_and_privacy/gpgapplet/gpgapplet_with_text.png

Maybe instead of having different screenshots for the different state we could instead:

  • Reuse wiki/src/doc/first_steps/introduction_to_gnome_and_the_tails_desktop/openpgp_applet.png to provide context.
  • Use the icons in /config/chroot_local-includes/usr/share/pixmaps/gpgApplet to clarify the state of the applet.

Subtasks

History

#1 Updated by spriver 2016-03-16 10:15:44

  • Assignee set to spriver

#2 Updated by spriver 2016-09-04 08:09:49

  • Status changed from Confirmed to In Progress

#3 Updated by spriver 2016-09-04 10:23:41

  • Assignee changed from spriver to sajolida
  • QA Check set to Ready for QA
  • Feature Branch set to spriver:feature/11243-OpenPGP-Applet-screenshots

I’m not 100% satisfied with the icons floating a bit higher than the text but I could not find any better solution. Please review! (:

#4 Updated by sajolida 2016-11-26 16:42:06

  • Status changed from In Progress to Resolved
  • Assignee deleted (sajolida)
  • QA Check deleted (Ready for QA)

Cool!

I fixed a bunch of minor issues and merged your branch. Some comments as usual, to improve your ninja skills for the future:

  • Commit 46804f5 was doing two changes at once: changing the icons and changing the alt tag. I’m fine with both but review and possible additional changes are easier if commits are more “atomic”. Of course there’s not clear cut on what’s good atomicity and what’s not as we’re always changing several bits at once :)
  • So I agree with your change to the alt tag: “with” was ambiguous here and “showing” is less. Now, since we’re also merging the img directive with the previous paragraph, both strings became fuzzy. If we had keep both strings separately, changing only the alt tag wouldn’t have affected people who don’t read the alt tag. As said already, I agree that “showing” is better than “with” here but seeing that the cost of improving what’s an invisible string for most people is to fuzz strings that are visible to everybody, I’m not sure I would have done it. Here again, there’s no clear cut when it’s ok or not to fuzz strings.
  • I fixed the vertical alignment issue with some CSS. We were already doing that for the “symbolic” class but these ones are a tiny bit bigger.