Bug #11228
Tor Browser AppArmor profile patch is outdated wrt. torbrowser-launcher 0.2.3-1
100%
Description
This breaks all test cases that verify that the system has started properly, and probably prevents Tor Browser from being confined or from working.
Subtasks
History
#1 Updated by intrigeri 2016-03-13 13:11:05
Actually, this should break the build, except we’re checking for .orig files before we apply that patch :]
#2 Updated by intrigeri 2016-03-13 13:16:01
- Status changed from Confirmed to In Progress
- % Done changed from 0 to 10
- Feature Branch set to bugfix/11228-refresh-Tor-Browser-AppArmor-profile
#3 Updated by intrigeri 2016-03-13 17:45:49
- Assignee changed from intrigeri to anonym
- % Done changed from 10 to 50
- QA Check set to Ready for QA
Please merge into stable and devel, so one can run automated tests again and validate WIP. Thanks!
#4 Updated by anonym 2016-03-13 21:00:50
- Assignee changed from anonym to intrigeri
- QA Check changed from Ready for QA to Dev Needed
It seems you based your branch on feature/11143-harden-kernel. Please rebase on stable!
#5 Updated by anonym 2016-03-13 22:13:56
intrigeri wrote:
> Actually, this should break the build, except we’re checking for .orig files before we apply that patch :]
Yay! How about fixing this now too, then? :)
anonym wrote:
> It seems you based your branch on feature/11143-harden-kernel. Please rebase on stable!
That said, I did build the branch any way, and it works as far as I understand this. The build log simply says “patching file /etc/apparmor.d/torbrowser” (nothing about fuzzy chunks) and there’s no .orig in the resulting ISO. I’m expecting a swift merge. :)
(Meta: This is one of these instances I feel like I could just skip an unnecessary round-trip due to process, and just rebase the branch myself, and continue the review’m’merge.)
#6 Updated by intrigeri 2016-03-14 11:15:07
- Assignee changed from intrigeri to anonym
- QA Check changed from Dev Needed to Ready for QA
> It seems you based your branch on feature/11143-harden-kernel. Please rebase on stable!
Sorry, now fixed.
#7 Updated by intrigeri 2016-03-14 11:15:46
>> Actually, this should break the build, except we’re checking for .orig files before we apply that patch :]
> Yay! How about fixing this now too, then? :)
I could take a ticket with no milestone.
> (Meta: This is one of these instances I feel like I could just skip an unnecessary
> round-trip due to process, and just rebase the branch myself, and continue the
> review’m’merge.)
Absolutely.
#8 Updated by anonym 2016-03-14 13:46:44
- Status changed from In Progress to Fix committed
- Assignee deleted (
anonym) - % Done changed from 50 to 100
- QA Check changed from Ready for QA to Pass
intrigeri wrote:
> >> Actually, this should break the build, except we’re checking for .orig files before we apply that patch :]
>
> > Yay! How about fixing this now too, then? :)
>
> I could take a ticket with no milestone.
> > (Meta: This is one of these instances I feel like I could just skip an unnecessary
> > round-trip due to process, and just rebase the branch myself, and continue the
> > review’m’merge.)
>
> Absolutely.
Ok. I’ll might take some greater liberties in these cases in the future. I am the process blasphemer!
Any way, I’ve reviewed, tested and merged the new branch!
#9 Updated by intrigeri 2016-03-14 15:35:32
> Ok. I’ll might take some greater liberties in these cases in the future. I am the process blasphemer!
Good. I think that being more relaxed in really trivial cases will help us actually respect the process to the letter when it matters (which I sometimes have a hard time doing).
#10 Updated by anonym 2016-04-26 09:13:19
- Status changed from Fix committed to Resolved