Bug #11225
Known Issues: Add Gnome ATI Crash problem with workaround
Start date:
2016-03-12
Due date:
% Done:
100%
Subtasks
Related issues
Related to Tails - |
Resolved | 2016-02-09 |
History
#1 Updated by emmapeel 2016-03-13 09:17:06
- related to
Bug #11095: GNOME session fails to start with some AMD/ATI radeon GPU added
#2 Updated by intrigeri 2016-03-13 10:36:52
- Assignee changed from intrigeri to emmapeel
- QA Check changed from Ready for QA to Dev Needed
Here’s a quick first review to keep the ball rolling:
- Looks like the added paragraph should be in the “Problems starting Tails” section.
- It’s “GNOME”.
- Unless you’re positive that all these GPUs are only found in laptops, I suggest something more generic e.g. s/laptops/computers/.
- The error message should be styled with some CSS class, I think. (And then you won’t need quotes anymore.) Same for “Tails Greeter”. IIRC our doc style guide knows the details by heart (and I don’t :)
- The last sentence has no trailing period.
- The current phrasing suggests that the workaround is known to work on all these systems, which AFAIK is not the case (for most of them, we simply don’t know).
#3 Updated by mercedes508 2016-07-16 09:38:22
- Status changed from New to Confirmed
#4 Updated by emmapeel 2016-08-05 02:23:54
- Status changed from Confirmed to In Progress
- Assignee deleted (
emmapeel) - QA Check changed from Dev Needed to Ready for QA
please review again.
#5 Updated by intrigeri 2016-08-09 13:27:42
- Assignee set to intrigeri
I’ll try to handle this one, but anyone, feel free to steal it from me :)
#6 Updated by intrigeri 2016-08-11 11:05:58
- Assignee changed from intrigeri to emmapeel
- % Done changed from 0 to 30
- QA Check changed from Ready for QA to Dev Needed
- Starter changed from Yes to No
Thanks for working on this!
- “due to updated graphic drivers” seems too bold to me: we really don’t know, and it might be that GNOME Shell’s requirements are the reason, instead of the graphics drivers; I suggest just dropping this explanation.
- missing trailing period at the end of the paragraph that starts with “After the”
- maybe s/may fix the issue/fixes the issue/, perhaps? (not a blocker)
- I think we can drop “Since Tails 2.0.1”: 5 months ago it made sense to indicate that this was a recent regression, but IMO it does not anymore.
- s/start GNOME session/start the GNOME desktop/, perhaps?
- I would appreciate more atomic commits.
git add -p
is really useful :) - I think that “GPU” is too technical in this context. I’ve seen us use “graphics adapters” elsewhere but I’m not sure if that’s our preferred terminology.
#7 Updated by emmapeel 2016-08-26 03:35:08
- Assignee changed from emmapeel to intrigeri
- QA Check changed from Dev Needed to Ready for QA
Oops didn’t saw the suggestions about small commits… added your changes, what do you think?
#8 Updated by intrigeri 2016-08-27 02:36:38
- Status changed from In Progress to Resolved
- Assignee deleted (
intrigeri) - Target version set to Tails_2.6
- % Done changed from 30 to 100
- QA Check changed from Ready for QA to Pass
Merged, and added commit:cc23dd151cb6be47a3a26107c827a6cacbd8c8e8 on top (I guess you missed that part of my suggestion) to save one round-trip.