Bug #11203

Onion Circuits should handle missing geoipdb gracefully

Added by sst 2016-03-09 00:40:15 . Updated 2016-04-26 09:34:42 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Target version:
Tails_2.3
Start date:
2016-03-09
Due date:
% Done:

100%

Feature Branch:
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Onion Circuits
Deliverable for:

Description

A Debian user reported that when tor-geoipdb is missing, Onion Circuits currently does not show any circuit information at all. I would expect it to show just the IPs, without country information, and to show a short message informing the user about this situation.
I can see that this might be not an issue in Tails itself, but addressing it could help make Onion Circuits more robust in situations where there is less control about the Tor installation.

See Debian bug #817086 (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=817086).
I have attached a patch that implements this behaviour and would be happy to get some comments.

Cheers
Sascha

Files

allow-failing-country-lookup.patch (5410 B) sst, 2016-03-09 00:38:40

Subtasks

History

#1 Updated by emmapeel 2016-03-09 10:29:31

  • Affected tool set to Onion Circuits

#2 Updated by intrigeri 2016-03-13 11:33:10

  • Status changed from New to In Progress
  • Assignee set to alant
  • Target version set to Tails_2.3
  • % Done changed from 0 to 50
  • QA Check set to Ready for QA

Personally I would perhaps have gone the lazy way, i.e. making tor-geoipdb a hard dependency, but now that there’s a patch to handle it more nicely, let’s take it, shall we?

#3 Updated by intrigeri 2016-03-22 10:12:55

jvoisin volunteered to do some reviews of incoming patches against Onion Circuits => wanna take this one?

#4 Updated by jvoisin 2016-03-27 22:16:08

It works great on my machine, and the patch looks good to me.

#5 Updated by alant 2016-04-01 21:28:55

  • Status changed from In Progress to Fix committed
  • Assignee deleted (alant)
  • QA Check changed from Ready for QA to Pass

Thanks Sascha for your patch. I merged it with little modifications in variable names and ordering in commit 5186768. Next time, would you prefer me to provide feedback and let you polish the patch?

#6 Updated by sst 2016-04-02 11:49:55

Thanks for the merge! Whatever works best for you, I’m absolutely fine with any modifications.

#7 Updated by anonym 2016-04-26 09:13:17

  • Status changed from Fix committed to Resolved

#8 Updated by anonym 2016-04-26 09:34:42

  • % Done changed from 50 to 100