Bug #11195

Clicking on circuit in Onion Circuits doesn't display details when using bridge

Added by sajolida 2016-03-07 11:48:30 . Updated 2016-06-08 01:30:59 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Target version:
Start date:
2016-03-07
Due date:
% Done:

50%

Feature Branch:
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Onion Circuits
Deliverable for:

Description

  • When I’m connected to Tor
  • And open Onions Circuits
  • And click on a circuit
  • Then no details are displayed in the left pane

Subtasks


Related issues

Blocked by Tails - Feature #11443: Upgrade Onion Circuits to 0.4 Resolved 2016-05-18

History

#1 Updated by sajolida 2016-03-07 11:48:54

  • Assignee set to intrigeri
  • QA Check set to Info Needed

intrigeri: as the integrator of Onion Circuits in 2.2, can you confirm this?

#2 Updated by sajolida 2016-03-08 13:02:57

  • Subject changed from Clicking on circuit in Onion Circuits doesn't display details to Clicking on circuit in Onion Circuits doesn't display details when using bridge

Actually, this seems to happen only when using bridges, and not when connecting directly to Tor.

#3 Updated by emmapeel 2016-03-12 10:25:17

confirmed in Tails 2.2 with obfs4 bridges.

#4 Updated by intrigeri 2016-03-12 11:20:14

  • QA Check changed from Info Needed to Dev Needed

This has been confirmed ⇒ reassigning to the author of this program.

#5 Updated by intrigeri 2016-04-01 16:36:38

  • Assignee changed from intrigeri to alant
  • Target version set to Tails_2.3

#6 Updated by alant 2016-04-01 21:21:39

  • Status changed from Confirmed to Fix committed
  • Assignee changed from alant to sajolida
  • QA Check changed from Dev Needed to Ready for QA

This should be fixed in git master (commit 9043a5a)

#7 Updated by sajolida 2016-04-14 09:30:11

  • Assignee changed from sajolida to alant
  • QA Check changed from Ready for QA to Info Needed

Sorry for the delay but I’m not sure how to test this. I tried:

  1. git reset —hard 9043a5a
  2. sudo cp onioncircuits /usr/bin/onioncircuits
  3. onioncircuits

And then I still get nothing when clicking on a circuit but the following trace in the background:

** (onioncircuits:4004): WARNING **: Couldn't register with accessibility bus: Did not receive a reply. Possible causes include: the remote application did not send a reply, the message bus security policy blocked the reply, the reply timeout expired, or the network connection was broken.
Traceback (most recent call last):
  File "/usr/bin/onioncircuits", line 574, in display_node
    status_entry = self.controller.get_network_status(fingerprint)
  File "/usr/lib/python3/dist-packages/stem/control.py", line 1529, in get_network_status
    raise exc
  File "/usr/lib/python3/dist-packages/stem/control.py", line 1521, in get_network_status
    desc_content = self.get_info(query, get_bytes = True)
  File "/usr/lib/python3/dist-packages/stem/control.py", line 961, in get_info
    raise exc
  File "/usr/lib/python3/dist-packages/stem/control.py", line 913, in get_info
    stem.response.convert('GETINFO', response)
  File "/usr/lib/python3/dist-packages/stem/response/__init__.py", line 128, in convert
    message._parse_message(**kwargs)
  File "/usr/lib/python3/dist-packages/stem/response/getinfo.py", line 38, in _parse_message
    raise stem.InvalidArguments('552', 'GETINFO request contained unrecognized keywords: %s\n' % ', '.join(unrecognized_keywords), unrecognized_keywords)
stem.InvalidArguments: GETINFO request contained unrecognized keywords: ns/id/7B1749DAE33496CAF4C829447AC2657322461044


During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/bin/onioncircuits", line 518, in cb_treeselection_changed
    self.show_circuit_details(circuit)
  File "/usr/bin/onioncircuits", line 535, in show_circuit_details
    self.display_node(fp, nick)
  File "/usr/bin/onioncircuits", line 575, in display_node
    except stem.DescriptorUnavailable:
AttributeError: 'module' object has no attribute 'DescriptorUnavailable'
localuser:onioncircuits being removed from access control list

#8 Updated by sajolida 2016-04-26 07:26:26

  • Target version changed from Tails_2.3 to Tails_2.4
  • QA Check changed from Info Needed to Dev Needed

Tested again in 2.3 and this is not fixed.

#9 Updated by intrigeri 2016-05-04 03:48:48

  • Status changed from Fix committed to In Progress

sajolida wrote:
> Tested again in 2.3 and this is not fixed.

Indeed, commit 9043a5a was not imported as a quilt patch into the package shipped in Tails 2.3 (and given your test results above, it’s not 100% clear to me that this commit would fix the problem anyway).

#10 Updated by alant 2016-05-15 06:41:48

  • Assignee changed from alant to sajolida
  • QA Check changed from Dev Needed to Ready for QA

I tried again and found that my fix didn’t work with stem 1.2 (in Tails). I fixed this issue and tested inside Tails 2.3, and confirm the fix works. However, I’m forced to use a generic exception. Given stem 1.4 is in jessie-backports, I’d argue for upgrading stem in Tails, but that’s not blocking anything.

#11 Updated by intrigeri 2016-05-18 08:48:25

So, that’s part of the 0.4 upstream release, yeah :) Let’s try to get it into the devel branch, so that sajolida (or anyone else) can confirm that the bug is fixed.

#12 Updated by intrigeri 2016-05-18 08:48:39

  • % Done changed from 0 to 50

#13 Updated by intrigeri 2016-05-18 09:30:58

#14 Updated by sajolida 2016-05-18 15:54:32

  • Status changed from In Progress to Fix committed
  • Assignee deleted (sajolida)
  • QA Check deleted (Ready for QA)

I confirm that the bug is solved. And what a slick interface we have with these new user strings!

#15 Updated by sajolida 2016-05-18 15:57:01

  • QA Check set to Pass

#16 Updated by anonym 2016-06-08 01:30:59

  • Status changed from Fix committed to Resolved