Bug #11171

Split build task in Rakefile

Added by anonym 2016-02-26 13:57:21 . Updated 2020-01-01 13:44:41 .

Status:
Confirmed
Priority:
Low
Assignee:
Category:
Build system
Target version:
Start date:
2016-02-26
Due date:
% Done:

10%

Feature Branch:
feature/11171-split-rakefile-build-task
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

This might become a big more cleaner and Makefile like.

Also, since we cannot mount 9p filesystems with write easily (permissions-wise vs. the host, at least) our vagrant-libvirt setup has to write the artifacs to disk (inside the guest) as an intermediate step. If the build task is split up, the fetch can more easily be mixed in between the build and build dir teardown.

Files

0001-Build-system-retrieve-artifacts-directly-from-the-bu.patch (2057 B) intrigeri, 2020-01-01 13:39:04

Subtasks

Related issues

Related to Tails - Feature #6354: Migrate to vagrant-libvirt Resolved 2014-10-13

History

#1 Updated by anonym 2016-02-26 13:59:08

  • Status changed from Confirmed to In Progress
  • Assignee set to anonym
  • % Done changed from 0 to 10
  • QA Check set to Dev Needed
  • Feature Branch set to feature/11171-split-rakefile-build-task

WIP branch.

#2 Updated by anonym 2016-02-26 13:59:28

#3 Updated by anonym 2016-05-08 04:19:25

  • Target version deleted (Tails_2.4)

I might work on this sometime in the future if I there’s some additional reason for it — my current WIP indicates that it’s quite a bit of work, and the current motivation simply isn’t good enough.

#4 Updated by intrigeri 2017-05-17 08:49:21

Has the lack of this improvement been a problem when working in this area recently? If not, I suggest we reject this ticket.

#5 Updated by intrigeri 2019-08-30 20:30:48

  • Status changed from In Progress to Confirmed
  • Assignee deleted (anonym)
  • Priority changed from Normal to Low

anonym wrote:
> I might work on this sometime in the future if I there’s some additional reason for it — my current WIP indicates that it’s quite a bit of work, and the current motivation simply isn’t good enough.

I don’t think we’ve found some additional reason for it so far.

#6 Updated by intrigeri 2020-01-01 13:44:41

anonym wrote:
> Also, since we cannot mount 9p filesystems with write easily (permissions-wise vs. the host, at least) our vagrant-libvirt setup has to write the artifacs to disk (inside the guest) as an intermediate step.

Right. As demonstrated when using the attached commit, currently the main problem to avoid this intermediary step is that our build-tails script will delete the build directory on exit, so if it does not move the build artifacts somewhere else first, there’s nothing left for Rakefile to retrieve. To fix this, we would need to move the build dir cleanup work out of the build-tails script (ideally to the Rakefile IMO, so that we can use Ruby instead of shell, and updates to this code don’t invalidate existing Vagrant build boxes), so that rake build could run build-tails, then retrieve artifacts, and finally ensure the cleanup code is run. Whether the build task is split along the way seems to be an implementation detail to me: per se, it’s not necessary to do that in order to drop the aforementioned intermediate step and get the corresponding build performance benefits.