Feature #11147

Automatically save KeePassX database after every change by default

Added by segfault 2016-02-20 19:50:26 . Updated 2017-05-22 17:29:31 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Target version:
Start date:
2016-02-20
Due date:
% Done:

100%

Feature Branch:
Type of work:
Discuss
Blueprint:

Starter:
Affected tool:
Password Manager
Deliverable for:

Description

By default, KeePassX doesn’t save changes (including new password entries) until the database is saved by the user. If KeePassX is closed with unsaved changes, it asks the user if should save the changes before closing.

Because Tails’ shutdown immediately kills all running applications and doesn’t halt for the “Save modified file?” dialog, I propose that we add this option to the KeePassX settings file by default. While automatically saving changes might sound dangerous, because it could save accidental changes, I don’t think this would be a problem because KeePassX creates backup entries after each change by default (in the “Backup” group).

We also modify other settings in the KeePassX settings file, see config/chroot_local-includes/etc/skel/.config/keepassx/config.ini.
I would prepare a patch if you think this feature is desirable.


Subtasks


Related issues

Related to Tails - Bug #10061: Shutdown the GNOME session properly Rejected 2015-08-19
Related to Tails - Bug #12544: KeePassX lost the auto-save setting in Tails/Stretch Resolved 2017-05-16

History

#1 Updated by intrigeri 2016-02-20 20:04:25

  • Assignee set to segfault

Sounds like a good idea to me.

#2 Updated by segfault 2016-02-20 21:02:50

  • Status changed from New to Confirmed
  • QA Check set to Ready for QA

See https://gitlab.com/segfault_/tails/tree/feature/11147-autosave-keepassx

#3 Updated by sajolida 2016-02-21 13:30:29

  • related to Bug #10061: Shutdown the GNOME session properly added

#4 Updated by sajolida 2016-02-21 13:34:12

  • Assignee changed from segfault to anonym
  • Target version set to Tails_2.2

Sounds good to me to. I guess this can be put in 2.2, no? So marking as “Ready for QA” and assigned to anonym, the RM.

#5 Updated by anonym 2016-02-24 18:42:04

  • Status changed from Confirmed to Fix committed
  • Assignee deleted (anonym)
  • % Done changed from 0 to 100
  • QA Check changed from Ready for QA to Pass

This seems like a very sane default to me, and one that I’m happy to diverge from upstream for. :)

I couldn’t merge your branch as-is since it contains an unrelated commit, commit:cb0ad0b — please compare against devel in the future before sending pull requests! In this case it’s no problem, of course, since the branch is so simple, so I just cherry-picked the intended commit. Thanks for you contribution!

#6 Updated by segfault 2016-02-24 22:58:51

>I couldn’t merge your branch as-is since it contains an unrelated commit, cb0ad0b
Oops, sorry. I must have branched from the wrong branch.
>please compare against devel in the future before sending pull requests!
Will do.
>Thanks for you contribution!
Thanks for merging it :)

#7 Updated by anonym 2016-03-08 19:02:37

  • Status changed from Fix committed to Resolved

#8 Updated by sajolida 2017-05-16 10:41:10

  • related to Bug #12544: KeePassX lost the auto-save setting in Tails/Stretch added

#9 Updated by sajolida 2017-05-22 17:29:31

  • Affected tool set to Password Manager