Bug #11136

Unclear error message in WhisperBack when failing to connect to the server

Added by alant 2016-02-18 15:41:54 . Updated 2016-04-26 09:13:49 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Target version:
Tails_2.3
Start date:
2016-02-18
Due date:
% Done:

100%

Feature Branch:
Type of work:
Code
Blueprint:

Starter:
Affected tool:
WhisperBack
Deliverable for:

Description

As reported by Olivier Berger, when Tails is conected to a network but Tor cannot create a circuit to the destination WhisperBack shows an error with the “too many values to unpack” message, which ain’t exactly end-user friendly.

$ whisperback 
Exception in thread Thread-6: 
Traceback (most recent call last):
[...]
File "/usr/lib/python3/dist-packages/socks.py", line 459, in
connect dest_addr, dest_port = dest_pair ValueError: too many
values to unpack (expected 2)

socks assumes the host resolves to AF_INET and triggers a ValueError if it’s not the case. If a .onion address is given, it resolves to an AF_INET address and to an AF_INET6 address. If the 1st doesn’t connect, the 2nd is tried, which make socks trigger the ValueError. This issue is fixed upstream in socks, in which this situation raises a socket.error (https://github.com/Anorov/PySocks/commit/4081b79)

Subtasks

History

#1 Updated by alant 2016-02-18 15:47:22

  • Subject changed from Uncrear error message in WhisperBack when failing to connect to the server to Unclear error message in WhisperBack when failing to connect to the server

I belive I workaround this bug in WhisperBack master.

#2 Updated by alant 2016-02-18 15:50:07

  • Description updated

#3 Updated by alant 2016-02-18 16:19:45

  • Status changed from Confirmed to Fix committed
  • Assignee changed from alant to anonym
  • QA Check set to Ready for QA

I tested this py patching a live Tails and it works. Please review.

#4 Updated by intrigeri 2016-02-18 16:31:09

  • Status changed from Fix committed to In Progress
  • Target version set to Tails_2.2
  • Affected tool set to WhisperBack

#5 Updated by anonym 2016-02-24 18:31:05

  • Assignee changed from anonym to alant
  • QA Check changed from Ready for QA to Dev Needed

I can see no corresponding commit in WhisperBack’s master branch. Did you forget to push? Note that there’s still time to get this into Tails 2.2, if you provide the fix before noon 2016-03-07 CET.

#6 Updated by alant 2016-04-01 15:04:03

  • Assignee changed from alant to anonym
  • QA Check changed from Dev Needed to Ready for QA

Sorry I indeed forgot to push and then disappeared… shoudl be repaired now.

#7 Updated by intrigeri 2016-04-01 19:52:26

  • Target version changed from Tails_2.2 to Tails_2.3

(Tails 2.2 was released already.)

#8 Updated by anonym 2016-04-22 17:14:33

  • % Done changed from 0 to 20

A package (0.7.5) has been uploaded to the feature-pre-2.3-prep APT suite.

#9 Updated by anonym 2016-04-24 10:01:58

  • Status changed from In Progress to Fix committed
  • Assignee deleted (anonym)
  • % Done changed from 20 to 100
  • QA Check changed from Ready for QA to Pass

Package built and uploaded to stable’s and devel’s APT suites. This is the package that will end up in Tails 2.3 unless something unexpected happens.

#10 Updated by anonym 2016-04-26 09:13:49

  • Status changed from Fix committed to Resolved