Bug #11108

Rakefile should show uncommitted changes in error message

Added by hybridwipe 2016-02-12 13:45:09 . Updated 2016-03-08 19:02:46 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Build system
Target version:
Tails_2.2
Start date:
2016-02-12
Due date:
% Done:

100%

Feature Branch:
https://git-tails.immerda.ch/hybridwipe/tails/?h=feature/11108-improve-rakefile
Type of work:
Code
Blueprint:

Starter:
1
Affected tool:
Deliverable for:

Description

When building tails, if you have uncommitted changes, you’ll get an error when building. While that makes sense, I find it a bit confusing because I often don’t have ‘changes’ to anything committed, but stray diff / log files in my tree, that won’t affect the build. Running ‘git diff’ shows no changes. ‘git status’ of course shows those changes.

I’ll shortly push a branch to improve this by showing the output of git status in the error message.

Subtasks

History

#1 Updated by hybridwipe 2016-02-12 14:02:44

  • Assignee changed from hybridwipe to anonym
  • QA Check changed from Dev Needed to Ready for QA
  • Feature Branch set to https://git-tails.immerda.ch/hybridwipe/tails/?h=feature/11108-improve-rakefile

#2 Updated by anonym 2016-02-12 14:05:50

  • Status changed from New to Fix committed
  • % Done changed from 0 to 100

Applied in changeset commit:22125ee77e578888df161740292b185defe6eb66.

#3 Updated by anonym 2016-02-12 14:07:59

  • Assignee deleted (anonym)
  • QA Check changed from Ready for QA to Pass

Fastest review’n’merge ever? :)

#4 Updated by hybridwipe 2016-02-12 14:14:23

anonym wrote:
> Fastest review’n’merge ever? :)

Gold star! :)

#5 Updated by intrigeri 2016-02-13 01:29:40

> Fastest review’n’merge ever? :)

No: we sometimes have time of merge < time of review :P

#6 Updated by anonym 2016-03-08 19:02:46

  • Status changed from Fix committed to Resolved