Bug #11097

Most browser test suite scenarios fail on ISO images built from the devel branch

Added by intrigeri 2016-02-09 20:36:40 . Updated 2016-02-13 16:10:24 .

Status:
Resolved
Priority:
High
Assignee:
Category:
Test suite
Target version:
Tails_2.0.1
Start date:
2016-02-09
Due date:
% Done:

100%

Feature Branch:
bugfix/11097-tor-browser-fontconfig
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Browser
Deliverable for:

Description

Updating BrowserAddressBar.png allows most of these scenarios to go on further, but then they fail again, with Sikuli not able to find a picture that’s quite obviously on screen. I’ve tested with an ISO built from devel, and another one from the branch for Bug #9896.

These tests work fine on a 2.0 ISO.

I’m starting to wonder if the fonts fingerprinting defense affects the GUI enough to confuse Sikuli. Is it possible that commit:2af53484fd7503d3888aa738d0b16ce287d33b55 broke these tests?

Subtasks

Related issues

Related to Tails - Bug #11124: Update TorBrowserTailsRoadmap.png image Resolved 2016-02-13
Blocks Tails - Bug #9896: Abstract common parts of chroot browser configuration files Resolved 2015-08-04
Blocks Tails - Bug #7943: The Tor Browser cannot use -profile together with -app Resolved 2014-09-24

History

#1 Updated by intrigeri 2016-02-09 20:37:04

  • Priority changed from Normal to High

(It prevents me from reviewing and merging stuff like Bug #9896.)

#2 Updated by intrigeri 2016-02-09 20:37:21

  • blocks Bug #9896: Abstract common parts of chroot browser configuration files added

#3 Updated by anonym 2016-02-10 13:57:39

I guess the fix for Bug #11000 caused this; it was merged without much review or tests. So, this is a good reminder for me that we should never side step our work-flow, which I seem to need once per year or so. :S

So, in the journal I see this

audit: type=1400 audit(1455112581.640:27): apparmor="DENIED" operation="mkdir" profile="/usr/local/lib/tor-browser/firefox" name="/home/amnesia/.cache/fontconfig/" pid=4190 comm="firefox" requested_mask="c" denied_mask="c" fsuid=1000 ouid=1000


which perhaps is the explanation. Also, I hope it will fix the issue with all characters being empty white boxes in the file dialogs (for Save As, and Open) and probably other places.

#4 Updated by anonym 2016-02-10 14:21:09

anonym wrote:
> So, in the journal I see this
> […]
> which perhaps is the explanation.

I don’t think it is, at least if assuming that the following problems is related:

> Also, I hope it will fix the issue with all characters being empty white boxes in the file dialogs (for Save As, and Open) and probably other places.

… because disabling the AppArmor profile does not fix the boxes.

#5 Updated by anonym 2016-02-10 14:34:06

Undoing the fix for Bug #11000 (commit:2af5348) fixes both the issue with BrowserAddressBar.png and the empty boxes.

#6 Updated by intrigeri 2016-02-10 15:03:45

  • blocks Bug #7943: The Tor Browser cannot use -profile together with -app added

#7 Updated by anonym 2016-02-10 23:22:17

  • Status changed from Confirmed to In Progress

Applied in changeset commit:4173d78b97ad598aba59c91e7c742b8892a8341c.

#8 Updated by anonym 2016-02-10 23:25:43

  • Assignee changed from anonym to intrigeri
  • % Done changed from 0 to 50
  • QA Check set to Ready for QA
  • Type of work changed from Research to Code

So I had to update all images… including for the chroot browsers and Tor Launcher. What do you think about commit:a8021ec?

#9 Updated by intrigeri 2016-02-11 01:21:11

Code review passes. Will run some tests.

anonym wrote:
> What do you think about commit:a8021ec?

Makes sense to me. We never got to look into the Unsafe Browser’s web fingerprint anyway, and in its documented+intended use cases the attacker we would be trying to protect against has other means to tell we’re running Tails.

#10 Updated by intrigeri 2016-02-11 01:25:04

  • Feature Branch set to bugfix/11097-tor-browser-fontconfig

#11 Updated by intrigeri 2016-02-11 14:20:15

  • Status changed from In Progress to Fix committed
  • % Done changed from 50 to 100

Applied in changeset commit:d2f6fe03253eb90ce2326ee2d25ffc000082daf9.

#12 Updated by intrigeri 2016-02-11 14:26:46

  • Assignee deleted (intrigeri)
  • QA Check changed from Ready for QA to Pass

Regarding merging into stable: same comment as on Bug #7943#note-15. Sadly I can’t vouch for merging this branch only, since I didn’t test it in isolation.

#13 Updated by intrigeri 2016-02-12 13:18:20

  • Target version changed from Tails_2.2 to Tails_2.0.1

#14 Updated by bertagaz 2016-02-13 16:10:24

  • Status changed from Fix committed to Resolved

#15 Updated by bertagaz 2016-02-13 16:24:35

  • related to Bug #11124: Update TorBrowserTailsRoadmap.png image added