Tails

#1 Updated by sajolida 2016-04-01 10:37:53

• blocks #8538 added

#2 Updated by sajolida 2016-04-01 11:01:03

• Target version deleted (Tails_2.2)

#3 Updated by tchou 2016-08-18 07:23:07

• Assignee changed from tchou to sajolida
• QA Check set to Ready for QA
• Feature Branch set to web/11268-really-download-again

I did everything about DAVE in the web/11268-really-download-again branch.
If you want to merge some things but not everything I can create a separate branch (I did my first git cherry-pick today).

> extra vertical space.png
I think we don’t have anymore this cas (one the use decides that he uses the extension, there is no more torrent mentions). But I made it anyway smaller, by really removing the “i_have_iso” in b88d657203ec8693850b264d9199c8f3b9d64db4

> opacity.png
What is the problem with this one ? Opacity is here a feature, to make the focus on the current and comming steps.

> vertical alignment.png
Fixed in b88d657203ec8693850b264d9199c8f3b9d64db4 and f26d5428dd14aa35eaa2599b2f4133e339d92594

> vertical space.png
Done in 9b0018fa170dd5a81d168c1282b364385b850686

> retry.png
Fixed in d0e7245ad991f3fe60b67daa46027166a6103fd2

and fixes on “downloaded path” and on “download again”.

#4 Updated by sajolida 2016-08-25 09:30:21

• File retry again.png added
• Status changed from Confirmed to In Progress
• Assignee changed from sajolida to tchou
• QA Check changed from Ready for QA to Dev Needed

> I did everything about DAVE in the web/11268-really-download-again branch.
> If you want to merge some things but not everything I can create a separate branch (I did my first git cherry-pick today).

Nothing in the branch seemed dangerous so I merged it live into master to make it easier to debug :)

>> extra vertical space.png
> I think we don’t have anymore this cas (one the use decides that he uses the extension, there is no more torrent mentions). But I made it anyway smaller, by really removing the “i_have_iso” in b88d657203ec8693850b264d9199c8f3b9d64db4

Ack.

>> opacity.png
> What is the problem with this one ? Opacity is here a feature, to make the focus on the current and comming steps.

Ok, I thought you meant to have the check sign less transparent. But I’m fine.

>> vertical alignment.png
> Fixed in b88d657203ec8693850b264d9199c8f3b9d64db4 and f26d5428dd14aa35eaa2599b2f4133e339d92594

Ok!

>> vertical space.png
> Done in 9b0018fa170dd5a81d168c1282b364385b850686

Ok!

>> retry.png
> Fixed in d0e7245ad991f3fe60b67daa46027166a6103fd2

I still see the problem, see attachment.

> and fixes on “downloaded path” and on “download again”.

I found this broken and fixed it again.

#5 Updated by tchou 2016-09-12 06:22:40

• Assignee changed from tchou to sajolida
• QA Check changed from Dev Needed to Info Needed

>>> retry.png
>> Fixed in d0e7245ad991f3fe60b67daa46027166a6103fd2
> I still see the problem, see attachment.

An !important̀ was missing, but there is maybe extra things:

- I’m not shure that I’m really in the “failed” state when I dev (I just change the data-state=“pause” to data-state=“failed”

- the “download-message-failed” is not displayed.
- the mockup (/code/attachments/download/921/extension-20150828.fodg) does not show a “X” icon, maybe it’s not necessary to keep it.

#6 Updated by sajolida 2016-09-12 13:16:21

• Assignee changed from sajolida to tchou
• QA Check changed from Info Needed to Dev Needed

> - I’m not shure that I’m really in the “failed” state when I dev (I just change the `data-state=“pause”` to `data-state=“failed”`

I still see pretty much the same. You should try to reproduce a real a failure from Tails by disabling and enabling again the network and tweak the CSS from that. I don’t want to look at untested code anymore :(

> - the “download-message-failed” is not displayed.

Indeed.

> - the mockup (/code/attachments/download/921/extension-20150828.fodg) does not show a “X” icon, maybe it’s not necessary to keep it.

Up to you.

#7 Updated by tchou 2016-09-13 03:39:34

• Assignee changed from tchou to sajolida
• QA Check changed from Dev Needed to Ready for QA

sajolida wrote:
> > - I’m not shure that I’m really in the “failed” state when I dev (I just change the `data-state=“pause”` to `data-state=“failed”`
>
> I still see pretty much the same. You should try to reproduce a real a failure from Tails by disabling and enabling again the network and tweak the CSS from that. I don’t want to look at untested code anymore :(

Strange, could you make a screenshot ? With my TB the “retry” has a perfect padding.

>
> > - the “download-message-failed” is not displayed.
>
> Indeed.
added.

>
> > - the mockup (/code/attachments/download/921/extension-20150828.fodg) does not show a “X” icon, maybe it’s not necessary to keep it.
>
> Up to you.

removed.

tip: It’s possible to go in the fail mode while selecting “tor-browser” as a download folder. And I guess it’s a bug, I’ll have a deeper look later.

#9 Updated by sajolida 2016-09-25 11:12:53

• Status changed from In Progress to Resolved
• Assignee deleted (sajolida)
• QA Check deleted (Ready for QA)

So we can actually close this one, yeah!