Bug #10950

Bring gnome-sound-recorder back

Added by intrigeri 2016-01-16 14:22:22 . Updated 2017-04-20 14:34:02 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Hardware support
Target version:
Tails_2.12
Start date:
2016-09-04
Due date:
% Done:

100%

Feature Branch:
bugfix/10950-add-gnome-sound-recorder
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

It was installed on Tails/Wheezy, it’s not in 2.0~rc1. Maybe it’s fine this way, since we ship Audacity already?

Subtasks

Bug #11780: GNOME Sound Recorder unusable because of "invalid capture settings" Resolved

0
Feature #11791: Update documentation to mention GNOME Sound Recorder Resolved

100

History

#1 Updated by emmapeel 2016-01-16 14:30:03

Gnome-sound-recorder has no advantages respect to Audacity… and we ship Audacity already

#2 Updated by intrigeri 2016-01-16 14:50:28

  • Status changed from Confirmed to Resolved
  • Assignee deleted (intrigeri)
  • % Done changed from 0 to 100

emmapeel wrote:
> Gnome-sound-recorder has no advantages respect to Audacity…

FTR I beg to disagree (a very simple UI is an advantage, compared to a daunting one with tons of buttons everywhere), but this may not be a strong enough reason to ship two pieces of software that address very similar use cases.

Anyway, the one we mention in our documentation is Audacity. On XMPP emmapeel and I agreed on: we stop shipping GNOME sound recorder, and re-add it if anyone asks for it in the 3 months after 2.0 is out.

#3 Updated by hybridwipe 2016-06-25 19:13:54

intrigeri wrote:
> emmapeel wrote:
> > Gnome-sound-recorder has no advantages respect to Audacity…
>
> FTR I beg to disagree (a very simple UI is an advantage, compared to a daunting one with tons of buttons everywhere), but this may not be a strong enough reason to ship two pieces of software that address very similar use cases.

+1 (and I think it is enough reason, at least in this case). If we don’t want to include duplicate software, then there’s no reason to include gedit if we also ship LibreOffice Writer, either ;).

> Anyway, the one we mention in our documentation is Audacity. On XMPP emmapeel and I agreed on: we stop shipping GNOME sound recorder, and re-add it if anyone asks for it in the 3 months after 2.0 is out.

It’s been 5-6, but someone has:
https://mailman.boum.org/pipermail/tails-dev/2016-June/010756.html

#4 Updated by hybridwipe 2016-06-25 23:30:43

  • Category set to Hardware support
  • Status changed from Resolved to In Progress
  • Target version changed from Tails_2.0 to Tails_2.5
  • QA Check set to Ready for QA
  • Feature Branch set to bugfix/10950-add-gnome-sound-recorder
  • Type of work changed from Discuss to Code

https://git-tails.immerda.ch/hybridwipe/tails/commit/?h=bugfix/10950-add-gnome-sound-recorder

should take care of this

#5 Updated by BitingBird 2016-06-26 08:31:34

  • % Done changed from 100 to 50

The discussion should happen before the eview, probably.

#6 Updated by sajolida 2016-06-27 08:03:27

  • Assignee set to sajolida
  • Type of work changed from Code to Discuss

It seems like what we need is a discussion: https://mailman.boum.org/pipermail/tails-dev/2016-June/010759.html.

#7 Updated by sajolida 2016-06-27 08:05:15

I’ll build this branch to know how much GNOME Recorder adds to the ISO image.

#8 Updated by sajolida 2016-06-28 05:27:03

  • Assignee deleted (sajolida)
  • QA Check deleted (Ready for QA)
  • wget http://nightly.tails.boum.org/build_Tails_ISO_devel/lastSuccessful/archive/latest.iso gives me Length: 1151539200.
  • wget http://nightly.tails.boum.org/build_Tails_ISO_bugfix-10950-add-gnome-sound-recorder/lastSuccessful/archive/latest.iso also gives me Length: 1151539200.

I also downloaded both ISO images and checked their size and checksum and got the same result. It seems like the inclusion of gnome-sound-recorder has no impact whatsoever on the image size. Crazy. I didn’t test the ISO images.

#9 Updated by hybridwipe 2016-06-29 00:22:16

sajolida wrote:
> * wget http://nightly.tails.boum.org/build_Tails_ISO_devel/lastSuccessful/archive/latest.iso gives me Length: 1151539200.
> * wget http://nightly.tails.boum.org/build_Tails_ISO_bugfix-10950-add-gnome-sound-recorder/lastSuccessful/archive/latest.iso also gives me Length: 1151539200.
>
> I also downloaded both ISO images and checked their size and checksum and got the same result. It seems like the inclusion of gnome-sound-recorder has no impact whatsoever on the image size. Crazy. I didn’t test the ISO images.

I didn’t make them, can’t say. But I can say that when I build an image locally with that change, I get gnome-sound-recorder in .packages, and a ‘Sound Recorder’ menu item under ‘Sound & Video’ that wasn’t there before.

#10 Updated by intrigeri 2016-06-30 08:30:57

> It seems like the inclusion of gnome-sound-recorder has no impact whatsoever on the image size. Crazy.

We pad ISO files, so the current practical impact may very well be 0 (still, it may have a strictly positive practical impact at any point in the future).

#11 Updated by muri 2016-07-06 12:48:15

  • QA Check set to Ready for QA
  • Type of work changed from Discuss to Code

We talked about that at the monthly meeting:

We decided to add gnome-sound-recorder back to tails.
If we had to decide between audacity and gnome-sound-recorder, we would ship
the latter, because its easier to use for inexpierenced users. The former could
be a case for the ‘additional software packages’, but we don’t want a
regression and there are usecases for audacity on Tails. Also g-s-r is really
tiny. Thats why we ship both.

Setting the ticket to Ready for QA, as there is already a bugfix

#12 Updated by intrigeri 2016-07-07 00:44:03

  • Subject changed from Consider installing gnome-sound-recorder on Jessie to Bring gnome-sound-recorder back
  • Assignee set to anonym
  • Target version changed from Tails_2.5 to Tails_2.6

#13 Updated by intrigeri 2016-07-29 14:25:15

  • Assignee changed from anonym to hybridwipe
  • QA Check changed from Ready for QA to Dev Needed

Can you please also look into updating the corresponding doc? git grep -w -i audacity -- wiki/src/**/*.mdwn wiki/src/**/*.html should point you to the places that might need an update.

#14 Updated by intrigeri 2016-07-31 01:53:21

  • Status changed from In Progress to Fix committed
  • % Done changed from 50 to 100

Applied in changeset commit:87b34ee5e839530c19953ef2c613c0d1fddb4688.

#15 Updated by sajolida 2016-09-04 03:43:39

  • Assignee changed from hybridwipe to sajolida

I’ll have to take over the documentation work I guess…

#16 Updated by intrigeri 2016-09-10 04:54:57

  • Status changed from Fix committed to In Progress

#17 Updated by intrigeri 2016-09-10 04:59:55

FTR we’ll have to revert this change unless Bug #11780 is fixed + the doc is updated in the next 46 hours. I’m sorry for the time pressure, I probably merged this too hastily last month :/

#18 Updated by intrigeri 2016-09-12 02:18:18

  • Assignee changed from sajolida to hybridwipe
  • Target version changed from Tails_2.6 to Tails_2.9.1

I’ve reverted this change on the testing branch for 2.6, and created Feature #11791 to track the doc update.

#19 Updated by sajolida 2016-09-13 11:34:51

The release notes snippet I wrote for this (and got removed) is:

-  - We installed again *GNOME Sound Recorder* to provide a very simple
-    application for recording sound in addition to the most complex *Audacity*.
XXX: Link to documentation (<del><a class='issue tracker-1 status-3 priority-4 priority-default closed child' href='/code/issues/11780' title='GNOME Sound Recorder unusable because of &#34;invalid capture settings&#34;'>Bug #11780</a></del>)
XXX: Add screenshot

(I’ll try to reuse it for when this will get merged.)

#20 Updated by anonym 2016-12-14 20:11:22

  • Target version changed from Tails_2.9.1 to Tails 2.10

#21 Updated by intrigeri 2017-01-19 19:09:26

  • Target version changed from Tails 2.10 to Tails_2.12

#22 Updated by hybridwipe 2017-03-18 19:09:52

I’ve pushed a branch here that should fix this:
https://git-tails.immerda.ch/hybridwipe/tails/log/?h=bugfix/10950-add-gnome-sound-recorder
specifically:
https://git-tails.immerda.ch/hybridwipe/tails/commit/?h=bugfix/10950-add-gnome-sound-recorder&id=db8d34737e09026d156cc1e22edb9082cf0008ab

unfortunately I can’t build at the moment, not sure why, and I’ve gotten no replies on the tails-dev mailing list.

If someone can build and test that, it would be lovely (the change does work on my Debian machine).

#23 Updated by intrigeri 2017-03-20 10:00:53

Thanks! I don’t think we should install the package from sid on Tails 2.x (based on Jessie): this brings too much instability for us, e.g. the sid package may start pulling a newer libc6 or other crazy stuff at any point. Instead, I recommend that we add gstreamer1.0-pulseaudio to our packages list, and then file a ticket for 3.0 about removing this line once we install gnome-sound-recorder >=3.21.92-2. What do you think?

#24 Updated by hybridwipe 2017-03-22 08:58:01

intrigeri wrote:
> Thanks! I don’t think we should install the package from sid on Tails 2.x (based on Jessie): this brings too much instability for us, e.g. the sid package may start pulling a newer libc6 or other crazy stuff at any point. Instead, I recommend that we add gstreamer1.0-pulseaudio to our packages list, and then file a ticket for 3.0 about removing this line once we install gnome-sound-recorder >=3.21.92-2. What do you think?

Of course. You mentioned that in Bug #11780, my fault for missing it.

https://git-tails.immerda.ch/hybridwipe/tails/commit/?h=bugfix/10950-add-gnome-sound-recorder&id=b931bf34d8d778b4ca96fecb70996d9d599d5a12

I’ve got a build going that I’ll test tomorrow (bedtime).

#25 Updated by intrigeri 2017-03-22 09:19:11

> I’ve got a build going that I’ll test tomorrow (bedtime).

\o/

#26 Updated by hybridwipe 2017-03-23 04:58:37

intrigeri wrote:
> > I’ve got a build going that I’ll test tomorrow (bedtime).
>
> \o/

Works, tested recording myself and hearing my own voice played back.

#27 Updated by intrigeri 2017-03-23 07:26:04

> Works, tested recording myself and hearing my own voice played back.

Cool. Feel free to submit this branch for QA whenever you want :)
(https://tails.boum.org/contribute/merge_policy/)

#28 Updated by hybridwipe 2017-03-23 15:15:22

  • Assignee deleted (hybridwipe)
  • QA Check changed from Dev Needed to Ready for QA

intrigeri wrote:
> > Works, tested recording myself and hearing my own voice played back.
>
> Cool. Feel free to submit this branch for QA whenever you want :)
> (https://tails.boum.org/contribute/merge_policy/)

Thanks for reminder.

#29 Updated by intrigeri 2017-03-25 07:48:30

  • Assignee set to anonym

(anonym is the release manager for 2.12 :)

#30 Updated by anonym 2017-04-03 18:09:06

  • Status changed from In Progress to Fix committed
  • Assignee deleted (anonym)
  • QA Check changed from Ready for QA to Pass

Thanks for the fix, hybridwipe! Merged!

#31 Updated by anonym 2017-04-03 19:21:12

  • % Done changed from 0 to 100

Applied in changeset commit:b75104652a6187e1b54abcbde8f37931a0c856ba.

#32 Updated by anonym 2017-04-19 17:25:52

  • Status changed from Fix committed to Resolved