Bug #10907

usb_install.feature fails when run as part of the entire test suite

Added by intrigeri 2016-01-12 13:17:28 . Updated 2016-01-27 13:33:43 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Test suite
Target version:
Tails_2.0
Start date:
2016-01-12
Due date:
% Done:

100%

Feature Branch:
test/10907-fix-badly-named-disk
Type of work:
Research
Blueprint:

Starter:
Affected tool:
Installer
Deliverable for:

Description

… but it succeeds when run first.

Files

test.feature.bad (3496 B) intrigeri, 2016-01-14 13:50:15
test.feature.good (2878 B) intrigeri, 2016-01-14 13:50:18

Subtasks

Related issues

Blocks Tails - Bug #10720: Tails Installer freezes when calling system_partition.call_set_name_sync in partition_device Resolved 2015-12-07

History

#1 Updated by intrigeri 2016-01-12 13:17:38

  • blocks Bug #10720: Tails Installer freezes when calling system_partition.call_set_name_sync in partition_device added

#2 Updated by intrigeri 2016-01-12 14:03:05

Running features/totem.feature features/untrusted_partitions.feature features/usb_install.feature seems to be enough to trigger the bug.

#3 Updated by intrigeri 2016-01-13 14:28:50

Trying these two test suite runs:

  • features/totem.feature features/untrusted_partitions.feature features/usb_install.feature
  • features/totem.feature features/usb_install.feature

#4 Updated by intrigeri 2016-01-14 11:02:26

  • features/totem.feature features/usb_install.feature fails
  • features/untrusted_partitions.feature features/usb_install.feature passes

#5 Updated by intrigeri 2016-01-14 13:50:44

OK, I’ve bisected it a bit more, see attachments.

#6 Updated by anonym 2016-01-19 00:31:24

Thanks a lot for the bisection! Looking at the diff, the issue seems obvious:

-  Scenario: Try installing Tails to a too small USB drive
-    Given I have started Tails from DVD without network and logged in
-    And I temporarily create a 2 GiB disk named "too-small-device"
-    And I start Tails Installer in "Clone & Install" mode
-    But a suitable USB device is not found
-    When I plug USB drive "too-small-device"
-    Then Tails Installer detects that a device is too small
-    And a suitable USB device is not found
-    When I unplug USB drive "too-small-device"
-    And I create a 4 GiB disk named "current"
-    And I plug USB drive "current"
-    Then the "current" USB drive is selected


We create a drive “current” which then over-writes the disk of the same name we internally use in our snapshots. :) I’ll fix this and give it a shot.

#7 Updated by anonym 2016-01-19 00:49:20

  • Status changed from Confirmed to In Progress

Applied in changeset commit:3e8ef9088901514e89ab29c2016cf7ca703eccc1.

#8 Updated by anonym 2016-01-19 00:50:30

  • Assignee changed from anonym to intrigeri
  • % Done changed from 0 to 50
  • QA Check set to Ready for QA
  • Feature Branch set to test/10907-fix-badly-named-disk

Yippie! :)

#9 Updated by intrigeri 2016-01-19 09:19:16

Thanks! Merged into bugfix/10720-installer-freezes-on-jenkins, we’ll see how it goes on Jenkins.

#10 Updated by intrigeri 2016-01-19 15:38:19

  • Status changed from In Progress to Fix committed
  • % Done changed from 50 to 100

Applied in changeset commit:74537f2d49490f6c2c3b39cd7fbe809f25a83b45.

#11 Updated by intrigeri 2016-01-19 15:39:26

  • Assignee deleted (intrigeri)
  • QA Check changed from Ready for QA to Pass

Great, thanks!

#12 Updated by anonym 2016-01-27 13:33:43

  • Status changed from Fix committed to Resolved