Feature #10858

Upgrade Tor Browser to 5.5

Added by intrigeri 2016-01-05 17:22:39 . Updated 2016-01-27 13:31:31 .

Status:
Resolved
Priority:
Elevated
Assignee:
Category:
Target version:
Tails_2.0
Start date:
2016-01-05
Due date:
% Done:

100%

Feature Branch:
feature/10858-tor-browser-5.5
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Browser
Deliverable for:

Description

The current plan is that there won’t be any 5.0.x released on Jan 26, so we need to switch to 5.5 for Tails 2.0.

Subtasks

Related issues

Related to Tails - Bug #10983: Upgrade Tor Browser to 5.5 final release Resolved 2016-01-22

History

#1 Updated by intrigeri 2016-01-05 17:23:39

  • Assignee set to intrigeri

I’ll at least prepare a branch that installs some recent TB 5.5 release.

#2 Updated by intrigeri 2016-01-05 17:27:02

  • Feature Branch set to feature/10858-tor-browser-5.5

#3 Updated by intrigeri 2016-01-05 22:15:34

anonym told me a few months ago that we should set intl.locale.matchOS = true, and then the appropriate localization should be used automatically depending on $LANG, so we
should be able to kill all our own locale guessing code.

#4 Updated by intrigeri 2016-01-05 23:19:30

  • Status changed from Confirmed to In Progress
  • Assignee changed from intrigeri to anonym
  • % Done changed from 0 to 10

@anonym:

  • Short-term: it builds, it boots, and I get a working Tor Browser with the correct default search engine in English, Japanese, and Italiano. Wanna run the relevant automated tests on it, and we merge that in time for 2.0~rc1, so that its manual test suite discovers what you and I would have missed? (Tor Browser is one of those areas where our manual tests still check quite a lot of stuff.)
  • Mid-term, regarding “we should be able to kill all our own locale guessing code”: that’s great news, but it’s not immediately needed, and really… not this month. If you agree, may you file a ticket about it, perhaps as part of the codebase clean ups plans you had started to draw somewhere in a corner of Redmine?

#5 Updated by intrigeri 2016-01-05 23:20:59

  • QA Check set to Ready for QA

#6 Updated by anonym 2016-01-07 12:53:21

First, I pushed commit commit:cd38ba2 because more disk space is now needed to build Tails (thanks to the addition of the Japanese Tor Browser tarball).

Second, I will wait with merging this until we know what to do regarding the Tor Browser 5.0.7 — the fixes it has is not in any 5.5 release yet.

#7 Updated by anonym 2016-01-07 14:15:43

intrigeri wrote:
> anonym told me a few months ago that we should set intl.locale.matchOS = true, and then the appropriate localization should be used automatically depending on $LANG, so we
> should be able to kill all our own locale guessing code.

Notice that my comment was for when we install a multi-language Tor Browser (e.g. the hardened versions). I am not sure this will work with the single-language bundles — it did not when I looked at it last time, six months ago or so.

#8 Updated by intrigeri 2016-01-08 11:34:43

> Second, I will wait with merging this until we know what to do regarding the Tor Browser 5.0.7 — the fixes it has is not in any 5.5 release yet.

Sure!

#9 Updated by intrigeri 2016-01-08 11:35:25

> Notice that my comment was for when we install a multi-language Tor Browser […]

Ooops, I was totally confused. For some reason, I thought that 5.5 would be multi-language only.

#10 Updated by anonym 2016-01-11 03:37:37

  • Assignee changed from anonym to intrigeri
  • % Done changed from 10 to 50

Now the full test suite passes for me => ready for merging into devel. If you agree with commit:2f16f2d and merge the branch I’ll file a ticket so we won’t forget following up before Tails 2.0 final (the final TB 5.5 should have a saner window resizing mechanism so we can revert commit:2f16f2d).

#11 Updated by intrigeri 2016-01-11 13:02:17

> If you agree with commit:2f16f2d and merge the branch I’ll file a ticket so we won’t forget following up before Tails 2.0 final

I’ll merge the branch modulo one change I just requested on XMPP, so please file the ticket :)

#12 Updated by intrigeri 2016-01-11 13:40:43

  • Status changed from In Progress to Fix committed
  • % Done changed from 50 to 100

Applied in changeset commit:ed876c881e520b3e4d7d7ae0d19295b144fa6c32.

#13 Updated by intrigeri 2016-01-11 13:42:12

  • Assignee deleted (intrigeri)
  • QA Check changed from Ready for QA to Pass

OK, merged. I didn’t want to block the RC building more, so I didn’t build nor test, and will fully trust your automated test suite run + all the tests we’ll do tomorrow on the ISO.

#14 Updated by anonym 2016-01-22 19:36:06

  • related to Bug #10983: Upgrade Tor Browser to 5.5 final release added

#15 Updated by anonym 2016-01-27 13:31:31

  • Status changed from Fix committed to Resolved