Bug #10784

Dotfiles persistent feature is broken on Jessie

Added by intrigeri 2015-12-21 06:28:32 . Updated 2016-01-27 13:31:29 .

Status:
Resolved
Priority:
Elevated
Assignee:
Category:
Persistence
Target version:
Tails_2.0
Start date:
2015-12-21
Due date:
% Done:

100%

Feature Branch:
bugfix/persistence-fixes-for-2.0-take1
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

Symlinks point to /lib/live/mount/persistence/TailsData_unlocked/dotfiles/, but /lib/live/mount/persistence/ does not exist. We should either add a symlink to make this still work, or point to /live/persistence/ instead.

Subtasks

Related issues

Related to Tails - Bug #10840: Automatically test dotfiles persistence Resolved 2016-01-03

History

#1 Updated by intrigeri 2015-12-28 03:46:53

sajolida uses this workaround:

install -m 755 -d /lib/live/mount/persistence
install -m 755 -d /lib/live/mount/persistence/TailsData_unlocked
mount --bind /live/persistence/TailsData_unlocked /lib/live/mount/persistence/TailsData_unlocked

#2 Updated by intrigeri 2015-12-31 02:26:37

  • Subject changed from Dotfiles persistent feature seems to be broken on Jessie to Dotfiles persistent feature is broken on Jessie

#3 Updated by intrigeri 2015-12-31 10:20:30

Seems like this commit in live-boot updated most paths, but not all, from /lib/live/mount/persistence to /live/persistence:

commit 9555545410914f4f6cf1b1c00bb4a5b5dfe2b5cc
Author: Gaudenz Steinlin <gaudenz@debian.org>
Date:   Tue Feb 12 08:14:17 2013 +0100

    Fixing mounting of rootfs, cow and medium filesystems (Closes: #696495).

Not sure if it was on purpose. I’ll try adjusting all remaining paths, and we’ll see.

#4 Updated by intrigeri 2016-01-01 04:02:04

  • Status changed from Confirmed to In Progress
  • % Done changed from 0 to 10

Actually, I think there’s nothing to be fixed in live-boot: the generated links are correct in the supported use case (persistence initialized at initramfs time), because components/9990-main.sh does “Move all mountpoints below /live into /root/lib/live/mount” after setting up persistence. Our own config/chroot_local-includes/usr/local/sbin/live-persist mounts stuff in /live/persistence instead, which is why the generated links are wrong. We have lots of Tails-specific stuff that depends on the /live/persistence path, so I think I’ll just try adding a symlink to it from /lib/live/mount/persistence.

#5 Updated by intrigeri 2016-01-01 06:09:57

  • Assignee changed from intrigeri to anonym
  • % Done changed from 10 to 50
  • QA Check set to Ready for QA
  • Feature Branch set to bugfix/10831-update-nopersistent-boot-parameter

#6 Updated by intrigeri 2016-01-01 11:04:18

  • Feature Branch changed from bugfix/10831-update-nopersistent-boot-parameter to bugfix/persistence-fixes-for-2.0-take1

#7 Updated by intrigeri 2016-01-01 14:43:21

@kytv: can you please add this bug to your list of needed regression tests, for some milestone in 2016Q2?

#8 Updated by anonym 2016-01-03 13:47:18

  • Status changed from In Progress to Fix committed
  • % Done changed from 50 to 100

Applied in changeset commit:aeee0d93b4ae60cd187417659a4821fb2402cba0.

#9 Updated by anonym 2016-01-03 13:54:19

  • Assignee deleted (anonym)
  • QA Check changed from Ready for QA to Pass

I thought we already (automatically) tested this, but indeed we explicitly do not. Fearing that kytv may miss your comment, I quickly created Bug #10840.

#10 Updated by intrigeri 2016-01-03 14:30:54

  • related to Bug #10840: Automatically test dotfiles persistence added

#11 Updated by anonym 2016-01-27 13:31:29

  • Status changed from Fix committed to Resolved