Bug #10782

Regression in "I synchronize keys in Seahorse" recovery_proc

Added by intrigeri 2015-12-20 22:56:38 . Updated 2016-01-27 13:31:28 .

Status:
Resolved
Priority:
Elevated
Assignee:
Category:
Test suite
Target version:
Tails_2.0
Start date:
2015-12-20
Due date:
% Done:

100%

Feature Branch:
test/10782-restart-seahorse-in-same-manner
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

commit:889411fdc54afbbd56ba4ef4858806d13690d220 did:

@@ -120,7 +117,7 @@ Then /^I synchronize keys in Seahorse$/ do
     if @screen.exists('GnomeCloseButton.png') || !$vm.has_process?('seahorse')
       step 'I kill the process "seahorse"' if $vm.has_process?('seahorse')
       debug_log('Restarting Seahorse.')
-      start_or_restart_seahorse(withapplet = @withgpgapplet)
+      start_or_restart_seahorse(withgpgapplet)
     end
   end

… but withgpgapplet is not defined in this scope. I think this was exactly why kytv used something with broader scope than a local variable in the first place.

In practice, I think it means that if the initial sync fails, and we meant to test with Seahorse started from the OpenPGP applet, then the retries will be run from a Seahorse started differently, which is not what we want to test in this case.

Subtasks

History

#1 Updated by anonym 2016-01-08 21:39:38

Wow. Good catch! :)

#2 Updated by anonym 2016-01-08 22:28:00

  • Status changed from Confirmed to In Progress

Applied in changeset commit:ada1297ac183016ea2c868d5dc188999e6f55cd1.

#3 Updated by anonym 2016-01-08 22:30:45

  • Assignee changed from anonym to kytv
  • % Done changed from 0 to 50
  • QA Check set to Ready for QA
  • Feature Branch set to test/10782-restart-seahorse-in-same-manner

#4 Updated by intrigeri 2016-01-16 15:50:57

kytv: in case you can’t handle this review within a week from now, please let me know, so I take it over. Note that I won’t be able to do it after Jan 21, so I need to know pretty quickly.

#5 Updated by anonym 2016-01-18 03:11:43

  • Assignee changed from kytv to intrigeri

intrigeri wrote:
> kytv: in case you can’t handle this review within a week from now, please let me know, so I take it over. Note that I won’t be able to do it after Jan 21, so I need to know pretty quickly.

Since we haven’t heard anything from kytv yet I’m assigning it to you, as decided earlier.

#6 Updated by intrigeri 2016-01-18 11:13:35

  • % Done changed from 50 to 60

Code review passes, testing.

#7 Updated by intrigeri 2016-01-18 12:54:23

  • Assignee changed from intrigeri to anonym
  • % Done changed from 60 to 70

features/encryption.feature features/torified_gnupg.feature pass for me once I apply the change I’ve pushed to the topic branch => please review and merge.

#8 Updated by anonym 2016-01-19 17:20:13

  • Status changed from In Progress to Fix committed
  • % Done changed from 70 to 100

Applied in changeset commit:45de9cf14f2defdade18dad75a4dec920c9a2340.

#9 Updated by anonym 2016-01-19 17:21:20

  • Assignee deleted (anonym)
  • QA Check changed from Ready for QA to Pass

#10 Updated by anonym 2016-01-27 13:31:28

  • Status changed from Fix committed to Resolved