Bug #10774

MAC address spoofing failure notifications are not always displayed

Added by intrigeri 2015-12-18 06:34:58 . Updated 2019-04-08 10:50:32 .

Status:
Confirmed
Priority:
Normal
Assignee:
Category:
Spoof MAC
Target version:
Start date:
2015-12-18
Due date:
% Done:

0%

Feature Branch:
test/10774-disable-mac-spoofing-notification-tests
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

It might be that the problem does not exist on Jessie, so I would recommend checking how it looks like on the branch that unmarks this scenario as fragile in a month or two.

Subtasks

Related issues

Related to Tails - Bug #11593: Network disabling does not always work Resolved 2016-07-22

History

#1 Updated by intrigeri 2015-12-18 06:48:55

  • Feature Branch set to test/10774-fragile-MAC_address_spoofing_fails_and_macchanger_returns_false

#2 Updated by intrigeri 2015-12-20 02:25:12

I suspect this is “just” a failure of our notification handling (either in Tails itself to show them, or in the test suite to find them on screen). We’ll see thanks to https://jenkins.tails.boum.org/view/Raw/job/test_Tails_ISO_test-10774-fragile-mac-address-spoofing-fails-and-macchanger-returns-false/ if Tails/Jessie has the same problem.

#3 Updated by intrigeri 2016-01-25 12:16:32

  • Subject changed from "MAC address spoofing fails and macchanger returns false" scenario is fragile to MAC address spoofing tests are fragile

“Scenario: MAC address spoofing fails and the module is not removed” fails very often as well, I’m going to flag it as fragile.

#4 Updated by anonym 2016-02-20 14:23:41

  • Priority changed from Normal to Elevated

#5 Updated by anonym 2016-02-20 14:51:30

  • Target version changed from Tails_2.3 to Tails_2.4

#6 Updated by anonym 2016-06-08 01:35:00

  • Target version changed from Tails_2.4 to Tails_2.5

#7 Updated by anonym 2016-07-18 06:42:55

  • Target version changed from Tails_2.5 to Tails_2.7

#8 Updated by intrigeri 2016-07-18 06:50:07

  • Deliverable for changed from 270 to SponsorS_Internal

#9 Updated by intrigeri 2016-07-22 05:37:57

  • Feature Branch changed from test/10774-fragile-MAC_address_spoofing_fails_and_macchanger_returns_false to wip/test/10774-fragile-MAC_address_spoofing_fails_and_macchanger_returns_false

#10 Updated by intrigeri 2016-08-18 07:34:39

  • Assignee deleted (anonym)
  • Target version deleted (Tails_2.7)
  • Deliverable for deleted (SponsorS_Internal)

#11 Updated by intrigeri 2016-08-31 04:57:28

  • related to Bug #11593: Network disabling does not always work added

#12 Updated by intrigeri 2018-08-17 07:57:22

  • Subject changed from MAC address spoofing tests are fragile to MAC address spoofing failure notifications are not always displayed
  • Category changed from Test suite to Spoof MAC

I’ve seen a few cases when these tests do fail and looking at the video, indeed the notification was never displayed, so I’m not convinced this is a test suite robustness issue, and I’m starting to think this is a real bug.

#13 Updated by intrigeri 2019-01-13 18:40:06

  • Status changed from Confirmed to In Progress

Applied in changeset commit:tails|26671c6e2c6361a12d284f0e95cdc78ecce9c146.

#14 Updated by intrigeri 2019-01-13 18:43:39

  • Status changed from In Progress to Confirmed

#15 Updated by anonym 2019-01-20 12:58:52

  • Assignee set to anonym
  • Target version set to Tails_3.12

intrigeri wrote:
> I’ve seen a few cases when these tests do fail and looking at the video, indeed the notification was never displayed, so I’m not convinced this is a test suite robustness issue, and I’m starting to think this is a real bug.

Confirmed! I looked at a run in detail, and while panic mode works the notification refuses to show. Explanation:

Jan 20 12:49:40 amnesia spoof-mac[4372]: Failed to unload module virtio_net of NIC eth0.
Jan 20 12:49:44 amnesia spoof-mac[5386]: Networking disabled
Jan 20 12:49:44 amnesia systemd-udevd[3983]: Process '/usr/local/lib/tails-spoof-mac eth0' failed with exit code 1.

I tried running show_notification() in a running session (as root) and that worked fine; it is very unclear to me how and where this error appears.

Hm, but I just realized that for me only the “MAC address spoofing fails and the module is not removed” scenario fails like this, but both “MAC address spoofing fails and macchanger returns true” and the “… false” scenarios manage to see the notification. The only difference is that in the failing case we run stop_and_disable_NM, but from the journal it seems that it ran successfully.

This is all I can afford for now.

#16 Updated by intrigeri 2019-01-25 08:40:36

  • Priority changed from Elevated to Normal

#17 Updated by anonym 2019-01-29 15:30:00

  • Target version changed from Tails_3.12 to Tails_3.13

#18 Updated by intrigeri 2019-03-04 11:24:29

  • Target version deleted (Tails_3.13)

> This is all I can afford for now.

Dropping target version, then.

#19 Updated by intrigeri 2019-03-25 07:45:39

  • Status changed from Confirmed to In Progress

Applied in changeset commit:tails|87663631fa3b33b91707a9e37653b6181f71ef8d.

#20 Updated by intrigeri 2019-03-25 07:47:38

  • Assignee changed from anonym to CyrilBrulebois
  • Target version set to Tails_3.14
  • QA Check set to Ready for QA
  • Feature Branch changed from wip/test/10774-fragile-MAC_address_spoofing_fails_and_macchanger_returns_false to test/10774-disable-mac-spoofing-notification-tests

@CyrilBrulebois, I’ve pushed a branch that removes the test suite steps that do nothing but annoy us, waste our time, and confirm we have a bug here. Please review and merge :) Once merged, set this back to Status = Confirmed, as the bug this is about is still here.

#21 Updated by anonym 2019-04-02 08:54:02

  • Assignee changed from CyrilBrulebois to anonym

#22 Updated by anonym 2019-04-02 10:42:44

  • Status changed from In Progress to Confirmed
  • Assignee deleted (anonym)
  • QA Check deleted (Ready for QA)

#23 Updated by intrigeri 2019-04-08 10:50:32

  • Target version deleted (Tails_3.14)