Bug #10718

Lower waiting time for USB installation in the test suite

Added by intrigeri 2015-12-06 16:07:59 . Updated 2015-12-16 11:33:46 .

Status:
Resolved
Priority:
Elevated
Assignee:
Category:
Test suite
Target version:
Start date:
2015-12-06
Due date:
% Done:

100%

Feature Branch:
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:
270

Description

We currently wait one hour:

  @screen.wait('USBInstallationComplete.png', 60*60)

… which is just the same as our Jenkins inactivity timeout, so in practice when Tails Installer fails and displays an error message, instead of reporting that the job failed (which is the point of the exercise) we abort the job due to this timeout (which communicates waaaay less clearly to me, with my Tails Installer developer hat, that there’s probably a bug I should fix, as opposed to “here’s a transient failure caused by instabilities of our Jenkins setup”). My understanding is that this is what prevented the Tails Installer bug described on Bug #10717 from being identified earlier, and I don’t want to see that happen again.

IIRC this 1h timeout was relevant for running with nested virtualization on slightly old (ThinkPad X200) hardware. I don’t think anyone does that anymore, and I would bet that on such hardware, lots of other bits of our test suite will time out anyway.

So I propose we decrease this to something like 30 minutes, i.e.:

  @screen.wait('USBInstallationComplete.png', 30*60)

If any of the watchers tells me to go ahead, and nobody raises concerns, I’ll just do it on stable, devel and feature/jessie.


Subtasks


History

#1 Updated by intrigeri 2015-12-06 16:08:16

  • Tracker changed from Feature to Bug

#2 Updated by bertagaz 2015-12-07 03:01:02

intrigeri wrote:
> … which is just the same as our Jenkins inactivity timeout, so in practice when Tails Installer fails and displays an error message, instead of reporting that the job failed (which is the point of the exercise) we abort the job due to this timeout (which communicates waaaay less clearly to me, with my Tails Installer developer hat, that there’s probably a bug I should fix, as opposed to “here’s a transient failure caused by instabilities of our Jenkins setup”). My understanding is that this is what prevented the Tails Installer bug described on Bug #10717 from being identified earlier, and I don’t want to see that happen again.
>
> So I propose we decrease this to something like 30 minutes, i.e.:
>
> […]

Makes sense, I guess it’s worth a try.

#3 Updated by intrigeri 2015-12-07 05:36:35

  • Type of work changed from Discuss to Code

I’ll go ahead then.

#4 Updated by intrigeri 2015-12-07 05:45:09

  • Status changed from Confirmed to Fix committed
  • % Done changed from 0 to 100

Applied in changeset commit:f10a95a598fd51601c38b700d790bb20d5c811f4.

#5 Updated by intrigeri 2015-12-07 05:45:48

  • Assignee deleted (intrigeri)

#6 Updated by anonym 2015-12-16 11:33:46

  • Status changed from Fix committed to Resolved
  • QA Check set to Pass