Bug #10660

Tails Installer 4.x crashes when a pristine USB drive is plugged

Added by intrigeri 2015-11-25 05:07:05 . Updated 2015-12-07 14:49:33 .

Status:
Resolved
Priority:
High
Assignee:
Category:
Installation
Target version:
Tails_2.0
Start date:
2015-11-25
Due date:
% Done:

100%

Feature Branch:
451f:liveusb-creator/bugfix/10660+dontcrashpristineusb
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Installer
Deliverable for:

Description

The fix for Bug #10539, or the last merge from master, introduced a regression in 4.4.4+dfsg-0tails2: when a pristine USB drive is plugged, the Installer crashes:

Traceback (most recent call last):
File "/usr/lib/tails_installer/tails-installer", line 105, in <module> main()
File "/usr/lib/tails_installer/tails-installer", line 99, in main win = TailsInstallerWindow(opts=opts, args=sys.argv)
File "/usr/lib/python2.7/dist-packages/tails_installer/gui.py", line 332, in __init__ self.populate_devices()
File "/usr/lib/python2.7/dist-packages/tails_installer/gui.py", line 523, in populate_devices
self.live.detect_supported_drives(callback=add_devices)
File "/usr/lib/python2.7/dist-packages/tails_installer/creator.py", line 701, in detect_supported_drives
callback()
File "/usr/lib/python2.7/dist-packages/tails_installer/gui.py", line 503, in add_devices
if not self.opts.partition and not self.live.device_can_be_upgraded(info):
File "/usr/lib/python2.7/dist-packages/tails_installer/creator.py", line 929, in device_can_be_upgraded
if self.is_partition_GPT(device) and device['fstype'] == 'vfat' \
File "/usr/lib/python2.7/dist-packages/tails_installer/creator.py", line 915, in is_partition_GPT
partition_table = self._udisksclient.get_partition_table(obj.props.partition)
TypeError: Argument 1 does not allow None as a value

Sounds like we assume too much wrt. the content of the drive we’re looking at.

(Identified by our automated test suite.)

Subtasks

Related issues

Blocks Tails - Feature #7563: Update the automated test suite for Jessie ISO images Resolved 2014-11-26 2016-01-15

History

#1 Updated by intrigeri 2015-11-25 05:07:17

  • blocks #8538 added

#2 Updated by intrigeri 2015-11-25 05:07:30

  • blocks Feature #8557: Have Tails Installer uploaded and accepted into Debian added

#3 Updated by intrigeri 2015-11-25 05:07:50

  • blocks Feature #7563: Update the automated test suite for Jessie ISO images added

#4 Updated by intrigeri 2015-11-25 05:09:48

  • Description updated

#5 Updated by intrigeri 2015-11-25 08:54:51

  • Subject changed from Tails Installer crashes when a pristine USB drive is plugged to Tails Installer 4.x crashes when a pristine USB drive is plugged

#6 Updated by intrigeri 2015-11-25 08:55:04

  • blocked by deleted (Feature #8557: Have Tails Installer uploaded and accepted into Debian)

#7 Updated by intrigeri 2015-11-25 08:55:58

  • Assignee set to intrigeri
  • Target version changed from Tails_1.8 to Tails_2.0

#8 Updated by intrigeri 2015-12-01 04:24:51

  • Target version changed from Tails_2.0 to Tails_1.8

I should fix that by December 15, so that at least the PPA and the .deb we ship ourselves work.

#9 Updated by Anonymous 2015-12-01 11:54:55

  • Status changed from Confirmed to In Progress
  • Assignee deleted (intrigeri)
  • % Done changed from 0 to 10

#10 Updated by Anonymous 2015-12-01 11:58:04

  • Assignee set to intrigeri
  • QA Check set to Ready for QA
  • Feature Branch set to 451f:liveusb-creator/bugfix/10660+dontcrashpristineusb

I let you review it.

#11 Updated by Anonymous 2015-12-01 13:37:54

I’ve tested on a Sid VM, using a pristine USB. I tried install and upgrade options.

I did not try on a USB stick containing Tails.

#12 Updated by intrigeri 2015-12-01 15:40:32

> I’ve tested on a Sid VM, using a pristine USB. I tried install and upgrade options.

I confirm it fixes the bug in these settings, yay! :)
It’s probably worth re-uploading to Debian, and perhaps, this time… to sid.

> I did not try on a USB stick containing Tails.

Thankfully this is well covered by our automated test suite. I’ll build + upload a package, and will trigger an ISO build + test so we’ll know soonish if it breaks anything else in that context.

#13 Updated by intrigeri 2015-12-01 15:43:25

  • % Done changed from 10 to 50

Merged into feature/jessie. Releasing & packaging will have to wait.

#14 Updated by intrigeri 2015-12-02 03:42:42

  • % Done changed from 50 to 60

Uploaded 4.4.6+dfsg-0tails1.

#15 Updated by intrigeri 2015-12-07 13:36:04

Passes features/usb_upgrade.feature here.

#16 Updated by intrigeri 2015-12-07 14:49:33

  • Status changed from In Progress to Resolved
  • Assignee deleted (intrigeri)
  • Target version changed from Tails_1.8 to Tails_2.0
  • % Done changed from 60 to 100
  • QA Check changed from Ready for QA to Pass

Also passes usb_install.feature => it’ll be worth uploading to Debian. I’ll do that after ftpmasters accept it into experimental, and we feel bold enough to upload to sid.