Feature #10634

Improve Download and verify (DAVE) - JS possible dependancy

Added by tchou 2015-11-24 02:18:29 . Updated 2015-12-20 09:44:47 .

Status:
Resolved
Priority:
Elevated
Assignee:
Category:
Target version:
Tails_2.0
Start date:
2015-11-24
Due date:
% Done:

0%

Feature Branch:
web/10634-DAVE-JS
Type of work:
Code
Blueprint:

Starter:
Affected tool:
ISO Verification Extension
Deliverable for:

Description

- Fix download in Firefox on Windows (0 MiB)

- Fix browser detection in Chrome
- Fix “You are using Firefox 1”

Subtasks

History

#1 Updated by sajolida 2015-11-24 02:44:29

#2 Updated by sajolida 2015-11-30 11:18:31

  • Priority changed from Normal to Elevated

ma1 will be unavailable from December 7 to 12, so it would be good to try this early this week.

#3 Updated by tchou 2015-12-12 07:11:40

  • Assignee changed from tchou to ma1

- Fix “You are using Firefox 1”
I don’t have acces to old Firefox version and failed to fake it with extensions.

- Fix download in Firefox on Windows (0 MiB)
I don’t have acces to windows computer to test it.

- Fix browser detection in Chrome
done in b05d3a5dee6a454b13e55dbcbf9e21a307a4def5

- Fix download resuming when changing network
discussed in Feature #10686

maone, I can not go deeper in this issues so I assign you.
say me if you need clarifications.

#4 Updated by tchou 2015-12-12 07:12:25

  • Feature Branch set to web/10634-DAVE-JS

#5 Updated by sajolida 2015-12-15 04:45:42

  • Assignee changed from ma1 to tchou
  • QA Check set to Info Needed

I don’t understand what you are expecting from Giorgio here. Can you clarify? Do you want him to review your changes? do the tests you cannot do? I think I should be the one to review your changes to the code as we’ve done in the past, and regarding the tests I think we anyway need to be able to validate his work.

I don’t have access to a Windows computer myself either. Maybe you should install yourself a virtual machine to be able to test, and possibly, fix this yourself?

Anything else that requires Giorgio’s eyes specifically?

#6 Updated by tchou 2015-12-15 06:24:52

sajolida wrote:
> I don’t understand what you are expecting from Giorgio here. Can you clarify? Do you want him to review your changes?

b05d3a5dee6a454b13e55dbcbf9e21a307a4def5 is in the JS, so it would not be a bad idea to have moane reviewing it, but I did not expected it.

It’s more about the 2 issues I can not solve.

> do the tests you cannot do? I think I should be the one to review your changes to the code as we’ve done in the past, and regarding the tests I think we anyway need to be able to validate his work.

> I don’t have access to a Windows computer myself either. Maybe you should install yourself a virtual machine to be able to test, and possibly, fix this yourself?

I tried to figure out what I could do in the CSS to fix the windows issue, but I have no idea. I can take 2 ou 3 hours to find and download on the internet a non trusted windows image, try to install it, and then try to fix this issue, but my feeling is that probably the probleme is in the extension.

Regarding the old firefox version, maybe it’s possible to find standalone old versions. I will have a look.

#7 Updated by tchou 2015-12-15 07:43:04

  • Assignee changed from tchou to sajolida
  • QA Check changed from Info Needed to Ready for QA

> Regarding the old firefox version, maybe it’s possible to find standalone old versions. I will have a look.

Using a portable FF30, the version is good.

#8 Updated by tchou 2015-12-16 09:24:05

I got a Windows XP virtual box image nown but I failed installing Virtualbox on my wheezy. Maybe next week on an other computer.

#9 Updated by sajolida 2015-12-16 10:42:19

  • Target version changed from Tails_1.8 to Tails_2.0

#10 Updated by sajolida 2015-12-17 08:07:01

  • Description updated
  • Assignee changed from sajolida to tchou
  • QA Check changed from Ready for QA to Dev Needed

So I merge the branch as of b05d3a5. So to sum up I updated the description of the ticket. The only issue left on this one is to test on Windows.

#11 Updated by tchou 2015-12-18 04:34:45

- success on win7 and FF42 - \o/
- success on win10 and FF43 - \o/
So maybe the bug we had with our win8 was specifiq to win8, or maybe it has been fixed.

- but fail to reconnize chrome47 - it reconnize it is an “unsupported browser” and display “you are running Firefox 1.0”
I tried to fix this, but I fail to know if the unsupported browser is an old firefox or any other IE, Chrome…

Maone any idea ?

#12 Updated by tchou 2015-12-18 04:56:10

  • Assignee changed from tchou to ma1

#13 Updated by tchou 2015-12-18 04:56:20

  • QA Check changed from Dev Needed to Info Needed

#14 Updated by ma1 2015-12-20 01:58:57

  • QA Check changed from Info Needed to Ready for QA

Latest dave.js (just pushed on git and available on maone.net) should fix the “false Firefox 1.0” detection issue.

Tested on Windows 8.1, works just like Windows 10 (as expected).

If verified looks like we can close this?

#15 Updated by tchou 2015-12-20 06:11:37

  • Assignee changed from ma1 to sajolida

- I merged maone changes on the branch.

#16 Updated by sajolida 2015-12-20 09:44:47

  • Status changed from Confirmed to Resolved
  • Assignee deleted (sajolida)
  • QA Check deleted (Ready for QA)

Cool, so I fixed some typos in tchou’s code (c34fddd and aba17b5) to synchronize again with Giorgio and merged this.