Tails

#1 Updated by alant 2015-11-17 10:17:19

• Priority changed from Normal to Low
• % Done changed from 0 to 50
• Feature Branch set to greeter:bugfix/10563-hide-windows-after-login

This should be fixed in https://git-tails.immerda.ch/greeter/log/?h=bugfix/10563-hide-windows-after-login

#2 Updated by intrigeri 2015-11-17 11:12:25

• Status changed from Confirmed to In Progress

Cool! Please reassign to me for QA once you deem it ready.

#3 Updated by alant 2015-11-17 12:01:12

• Assignee changed from alant to intrigeri
• QA Check set to Ready for QA

Please note I didn’t build a debian package but tested the modified file live.

#4 Updated by intrigeri 2015-11-17 13:40:07

• Priority changed from Low to Normal

Not 100% sure it’s a regression, and seems to depend on the hardware a lot, but still, the UX improvement seems to be worth the effort as long as the provided patch doesn’t introduce problems itself.

#5 Updated by intrigeri 2015-11-18 00:34:36

• Assignee changed from intrigeri to alant
• % Done changed from 50 to 70

I’ve split your commit so that the unrelated indentation changes are in a dedicated one, and then applied both. It would be helpful if you could avoid mixing up things in a single commit next time.

I felt that the hard-coded window list was problematic, so I changed the code you added to use the dynamically updated list of windows that we already have (commit ba20ca5f7349eab3acb82c4d81e60a0a181ab317).

May you please review the adjusted code I’ve pushed?

Uploaded current state as 0.8.14+jessie3.

#6 Updated by alant 2015-11-18 01:52:34

• Status changed from In Progress to Fix committed
• % Done changed from 70 to 100
• QA Check changed from Ready for QA to Pass

intrigeri wrote:
> I’ve split your commit so that the unrelated indentation changes are in a dedicated one, and then applied both. It would be helpful if you could avoid mixing up things in a single commit next time.
>
OK

> I felt that the hard-coded window list was problematic, so I changed the code you added to use the dynamically updated list of windows that we already have (commit ba20ca5f7349eab3acb82c4d81e60a0a181ab317).
>
It looks indeed better and I fail to see a problem with the new code.

> May you please review the adjusted code I’ve pushed?
>
> Uploaded current state as 0.8.14+jessie3.

Great, thanks!

#7 Updated by intrigeri 2015-11-18 05:45:36

• Status changed from Fix committed to Resolved

#8 Updated by intrigeri 2015-11-18 05:50:09

• Assignee deleted (alant)

#9 Updated by intrigeri 2020-04-15 06:01:53

• Affected tool changed from Greeter to Welcome Screen