Tails

#1 Updated by sajolida 2015-10-30 13:14:04

• blocks #8668 added

#2 Updated by sajolida 2015-10-30 13:14:43

• Assignee set to anonym

Assigning to anonym who’s coordinating all this. What do you think? I don’t think that’s a blocker or a big deal but that can be useful for some people.

#3 Updated by sajolida 2015-10-30 13:20:08

• Description updated

#4 Updated by sajolida 2015-12-01 07:40:21

• Assignee deleted (anonym)

anonym is not coordinating this anymore.

#5 Updated by Anonymous 2015-12-11 05:27:20

• Assignee set to kytv

Assigning to kytv. If you could do that, that would be nice, otherwise reassign back to me or anonym eventually. thanks!

#6 Updated by bertagaz 2015-12-11 06:22:51

• Assignee changed from kytv to bertagaz

Stealing it. I may propose something soon.

#7 Updated by bertagaz 2015-12-11 06:47:13

• Status changed from Confirmed to In Progress

Applied in changeset commit:37fdb31a2b7955594b161c62b0baf7917341b46c.

#8 Updated by bertagaz 2015-12-11 06:49:44

• Assignee changed from bertagaz to kytv
• % Done changed from 0 to 70
• QA Check set to Ready for QA
• Feature Branch set to feature/10458-icedove-warn-if-claws-mail-persistence-enabled

Pushed a branch with some code in the icedove wrapper to do that (based on the electrum one), and updated (correctly hopefully) the icedove feature. Please test and review.

#9 Updated by kytv 2015-12-11 14:29:07

• Assignee changed from kytv to bertagaz
• QA Check changed from Ready for QA to Dev Needed

I’ve built an ISO to test and the warning works. The changes to the test suite, however, do not since the Icedove tests don’t yet use persistence, therefore the warning isn’t seen while the test suite runs. This can of course be fixed with

 
   git reset --hard cbac48c454f369f301042565e086cd57b0e9b188

and force pushing.

I wonder though: Should the warning be shown whenever Claws’ persistence is enabled, or perhaps only when Claws’ persistence is enabled and we can tell that Icedove has never been started before?

If we show the warning each time Icedove is started when Claws’ persistence is enabled the migration guide should be updated to mention disabling the Claws preset. Otherwise the helpful warning would grow to be rather annoying for those users that don’t realize that they should disable the Claws-Mail preset.

#10 Updated by bertagaz 2015-12-13 04:53:53

• Assignee deleted (bertagaz)
• Type of work changed from Code to Discuss

kytv wrote:
> I’ve built an ISO to test and the warning works. The changes to the test suite, however, do not since the Icedove tests don’t yet use persistence, therefore the warning isn’t seen while the test suite runs. This can of course be fixed with

Oooh, good catch, didn’t check that.

> and force pushing.

Done.

> I wonder though: Should the warning be shown whenever Claws’ persistence is enabled, or perhaps only when Claws’ persistence is enabled and we can tell that Icedove has never been started before?
>
> If we show the warning each time Icedove is started when Claws’ persistence is enabled the migration guide should be updated to mention disabling the Claws preset. Otherwise the helpful warning would grow to be rather annoying for those users that don’t realize that they should disable the Claws-Mail preset.

Good point.

The documentation page about the migration actually tell people to wipe the content of the ${HOME}/.claws-mail directory at the end, so we could check that some file like accountrc exists and display the notification only if it does.

But in Feature #9499, we’ll have to remove the claws-mail persistent setting in tails-persistence-setup, so telling people to remove it from their persistence configuration after having done the migration makes sense somehow to be a bit more future-proof.

Assigning to U that is coordinating the work to decide which next action to take (update the code of this branch, or write a bit more documentation).

#11 Updated by Anonymous 2015-12-14 02:48:50

• Assignee set to bertagaz

bertagaz wrote:
> kytv wrote:
> > I wonder though: Should the warning be shown whenever Claws’ persistence is enabled, or perhaps only when Claws’ persistence is enabled and we can tell that Icedove has never been started before?

I think that’s the way to go. This would avoid that we need to update the documentation and avoid the annoying showing this message every time.

> > If we show the warning each time Icedove is started when Claws’ persistence is enabled the migration guide should be updated to mention disabling the Claws preset. Otherwise the helpful warning would grow to be rather annoying for those users that don’t realize that they should disable the Claws-Mail preset.
>
> Good point.
>
> The documentation page about the migration actually tell people to wipe the content of the ${HOME}/.claws-mail directory at the end, so we could check that some file like accountrc exists and display the notification only if it does.

yes!

> But in Feature #9499, we’ll have to remove the claws-mail persistent setting in tails-persistence-setup, so telling people to remove it from their persistence configuration after having done the migration makes sense somehow to be a bit more future-proof.

yes!

Reassigning to bertagaz. Please check with kytv who of you could do that? Thanks!

#12 Updated by bertagaz 2015-12-14 07:08:06

• Status changed from In Progress to Fix committed
• % Done changed from 70 to 100

Applied in changeset commit:f9816452b876a93e504be0f1b6c306f15e82e4ca.

#13 Updated by bertagaz 2015-12-14 07:10:27

• QA Check changed from Dev Needed to Pass
• Type of work changed from Discuss to Code

Merged it myself after having an approval from our dear beloved RM.

#14 Updated by intrigeri 2015-12-15 04:20:00

• Assignee deleted (bertagaz)

#15 Updated by anonym 2015-12-16 11:33:53

• Status changed from Fix committed to Resolved