Bug #10441
Synaptic test is fragile
100%
Description
Files
Subtasks
Related issues
Related to Tails - |
Resolved | 2015-10-23 | |
Blocks Tails - |
Resolved | 2016-01-12 | |
Copied to Tails - |
Rejected | 2015-10-28 |
History
#1 Updated by kytv 2015-10-28 07:20:42
- Status changed from New to Confirmed
- Parent task set to Bug #10288
#2 Updated by kytv 2015-10-28 07:26:51
- Status changed from Confirmed to In Progress
- Target version set to Tails_1.7
- Feature Branch set to kytv/test/10441-synaptic-test-is-fragile
#3 Updated by kytv 2015-10-28 07:27:22
- Target version changed from Tails_1.7 to Tails_1.8
#4 Updated by intrigeri 2015-10-31 05:52:16
- blocks #8668 added
#5 Updated by intrigeri 2015-10-31 05:52:45
(This ticket should not have a parent with a target version before its own one.)
#6 Updated by intrigeri 2015-11-06 06:07:31
- Assignee set to kytv
- Deliverable for set to 270
#7 Updated by kytv 2015-11-06 11:56:02
- Target version changed from Tails_1.8 to 246
#8 Updated by sajolida 2015-11-27 04:45:49
- Target version changed from 246 to Tails_2.0
#9 Updated by intrigeri 2015-12-05 13:22:08
- Target version changed from Tails_2.0 to Tails_2.2
(We’re going to mark as fragile all tests that depend on Tor to have bootstrapped for the moment => not so urgent. Besides, the move to Jessie and freezable APT repo can change things a bit.)
#10 Updated by anonym 2016-02-20 13:28:03
- blocks
Feature #10900: "I should be able to install a package using Synaptic" step is fragile added
#11 Updated by anonym 2016-02-20 13:29:26
- Target version changed from Tails_2.2 to Tails_2.4
#12 Updated by anonym 2016-03-03 15:52:27
- Assignee changed from kytv to anonym
I’ll try to improve this with Chutney (Feature #9521) and/or dogtail (Feature #7729) depending on exactly what the problem is.
#13 Updated by anonym 2016-06-02 14:50:05
- Feature Branch changed from kytv/test/10441-synaptic-test-is-fragile to test/10441-synaptic-test-is-fragile
The attached screenshot shows that fetching some indexes from deb.tails.boum.org failed. That does not seem specific to synaptic. I’ve pushed the topic branch which removes the @fragile
tag + merged devel. Let’s see what jenkins thinks.
#14 Updated by intrigeri 2016-06-05 13:09:43
- Target version changed from Tails_2.4 to Tails_2.6
- Deliverable for deleted (
270)
#15 Updated by bertagaz 2016-06-29 05:49:54
- % Done changed from 0 to 40
anonym wrote:
> The attached screenshot shows that fetching some indexes from deb.tails.boum.org failed. That does not seem specific to synaptic. I’ve pushed the topic branch which removes the @fragile
tag + merged devel. Let’s see what jenkins thinks.
It finds a few issue, as did the runs at home. I’ve pushed a few commits that should make this test more robust. Works well at home, let see what jenkins thinks about it (first Jenkins run is https://jenkins.tails.boum.org/job/test_Tails_ISO_test-10441-synaptic-test-is-fragile/29/)
#16 Updated by bertagaz 2016-07-04 05:54:25
- % Done changed from 40 to 50
- QA Check set to Ready for QA
The commits I’ve pushed in the branch are working fine and recovered from network errors during my testing. Works fine in Jenkins too.
So I think it’s ready for a review. Bug #10412 should be reviewed at the same time, given there is a workaround for this one too in this branch.
#17 Updated by bertagaz 2016-07-11 09:32:18
Note that this ticket branch has been merged into bugfix/10494-retry-htpdate-with-more-fragile-tests
, so it has also been tested in Jenkins in this other branch.
#18 Updated by intrigeri 2016-07-13 13:08:49
- related to
Bug #10412: Synaptic hangs after updating APT lists added
#19 Updated by intrigeri 2016-07-13 13:55:17
- blocked by deleted (
#8668)
#20 Updated by intrigeri 2016-07-13 14:00:59
- blocks
Bug #10494: Retry htpdate when it fails added
#21 Updated by intrigeri 2016-07-13 14:01:41
- blocked by deleted (
)Bug #10494: Retry htpdate when it fails
#22 Updated by intrigeri 2016-07-13 14:13:55
- Assignee changed from anonym to bertagaz
- QA Check changed from Ready for QA to Dev Needed
Here’s a quick initial code review, to ease anonym’s job.
The Git history seems broken: e.g. I see commit:23658c0276af07403f5c2b11992a124d1875cbb2 that seems to be a rewritten version of commit:2bb720275e933f33f8f8d6900257d1d5ac34f122 that is is devel. If it’s not too late, please fix this.
Here as well, please drop the if $vm.has_process?("synaptic")
check when killing processes (if I’m not mistaken, it’s racy and useless).
Please write 15*60
instead of 900
, for clarity’s sake.
!$vm.execute("pidof /usr/lib/apt/methods/tor+http").success?
<— don’t we have a nice helper to do that?
Please use apt
instead of apt-get
, for better consistency.
#23 Updated by bertagaz 2016-07-15 08:36:13
- Assignee changed from bertagaz to intrigeri
- QA Check changed from Dev Needed to Ready for QA
intrigeri wrote:
> The Git history seems broken: e.g. I see commit:23658c0276af07403f5c2b11992a124d1875cbb2 that seems to be a rewritten version of commit:2bb720275e933f33f8f8d6900257d1d5ac34f122 that is is devel. If it’s not too late, please fix this.
Right, my bad. This branch was based on devel at first, so I had to rebase it on stable, might be why. Fixed anyway.
> Here as well, please drop the if $vm.has_process?("synaptic")
check when killing processes (if I’m not mistaken, it’s racy and useless).
commit:d485b7b
> Please write 15*60
instead of 900
, for clarity’s sake.
commit:a14bef5
> !$vm.execute("pidof /usr/lib/apt/methods/tor+http").success?
<— don’t we have a nice helper to do that?
Ooh, right. Discovered it after this commit I guess… Fixed in commit:3572ed1
> Please use apt
instead of apt-get
, for better consistency.
commit:7acad4e
#24 Updated by intrigeri 2016-07-15 08:57:11
- Assignee changed from intrigeri to bertagaz
- QA Check changed from Ready for QA to Dev Needed
>> !$vm.execute("pidof /usr/lib/apt/methods/tor+http").success?
<— don’t we have a nice helper to do that?
> Ooh, right. Discovered it after this commit I guess… Fixed in commit:3572ed1
Cool. There’s if !$vm.execute("pidof synaptic").success?
left though.
#25 Updated by bertagaz 2016-07-15 09:05:35
- Assignee changed from bertagaz to intrigeri
- QA Check changed from Dev Needed to Ready for QA
intrigeri wrote:
> Cool. There’s if !$vm.execute("pidof synaptic").success?
left though.
O_o ooops… fixed in commit:886be18, sorry for the noise.
And many thanks for the reviews too!
#26 Updated by intrigeri 2016-07-16 08:50:04
- Assignee changed from intrigeri to anonym
#27 Updated by intrigeri 2016-07-23 06:08:57
- Assignee changed from anonym to bertagaz
- QA Check changed from Ready for QA to Dev Needed
Doesn’t merge cleanly anymore => please merge current stable into the topic branch, resolve conflicts and resubmit for QA.
#28 Updated by bertagaz 2016-07-24 04:04:56
- Assignee changed from bertagaz to intrigeri
- QA Check changed from Dev Needed to Ready for QA
intrigeri wrote:
> Doesn’t merge cleanly anymore => please merge current stable into the topic branch, resolve conflicts and resubmit for QA.
Right, done!
#29 Updated by intrigeri 2016-07-25 01:22:51
- Assignee changed from intrigeri to anonym
#30 Updated by anonym 2016-08-28 11:39:04
- Status changed from In Progress to Fix committed
- Assignee deleted (
anonym) - % Done changed from 50 to 100
- QA Check changed from Ready for QA to Pass
Your stuff looks good! Go bert, go!
#31 Updated by anonym 2016-09-20 16:47:24
- Status changed from Fix committed to Resolved
#32 Updated by intrigeri 2017-05-24 06:04:58
- copied to
Bug #12586: Synaptic test is fragile on Stretch added
#33 Updated by intrigeri 2017-05-24 06:09:04
- copied from deleted (
)Bug #12586: Synaptic test is fragile on Stretch
#34 Updated by intrigeri 2017-05-24 06:09:13
- related to
Bug #12586: Synaptic test is fragile on Stretch added
#35 Updated by intrigeri 2017-05-24 06:09:59
- related to deleted (
)Bug #12586: Synaptic test is fragile on Stretch
#36 Updated by intrigeri 2017-05-24 06:10:18
- copied to
Bug #12586: Synaptic test is fragile on Stretch added