Bug #10428
Disable add-on updates in Icedove
100%
Description
In config/chroot_local-includes/etc/icedove/pref/icedove.js
we have pref("extensions.update.enabled", true);
. We should disable it!
Subtasks
History
#1 Updated by sajolida 2015-10-27 11:14:36
Note that Tor Browser has update checking enabled, see https://tails.boum.org/blueprint/bootstrapping/extension#index9h1. So that doesn’t sound that bad and in the context of the ISO verification extension we actually want this.
#2 Updated by intrigeri 2015-10-27 12:54:05
(I’m a little bit confused by the Tor Browser -specific comments on a ticket about Icedove, please bare with me if I got it wrong.)
> Note that Tor Browser has update checking enabled, see https://tails.boum.org/blueprint/bootstrapping/extension#index9h1. So that doesn’t sound that bad
Basically the same rationale as for “don’t run apt-get upgrade
” applies for other kinds of code, such as plugins/add-ons/you-name-it.
I’m not saying it will break stuff, just that so far we have been disabling add-on update checking in Tails’ Tor Browser, so changing this is unknown territory, and we would need a pretty good motivation + time to explore it (allowing/encouraging partial system upgrades controlled by the user would make it quite more complicated to reason about Tails from a systems engineering point-of-view, so it’d better be worth it).
But of course, if someone wants to explore it after 1.7 is out with Icedove add-ons update checks disabled, by all means please do :)
> and in the context of the ISO verification extension we actually want this.
Not in Icedove, I guess.
#3 Updated by intrigeri 2015-10-27 16:06:31
- blocks #8668 added
#4 Updated by intrigeri 2015-10-27 16:06:41
- Deliverable for set to 268
#5 Updated by intrigeri 2015-10-27 16:07:01
- Parent task set to
Feature #5663
#6 Updated by anonym 2015-10-28 03:50:54
“What intrigeri said”.
PS. Sorry for being vague in the description!
#7 Updated by sajolida 2015-10-28 08:27:01
> (I’m a little bit confused by the Tor Browser -specific comments on a ticket about Icedove, please bare with me if I got it wrong.)
I thought that Tor Browser in Tails also had automatic upgrades enabled.
From your comment and from the code, I now understand that this is not
the case. So my comment becomes irrelevant and we should of course do
the same as everywhere else then: no automatic upgrades outside of IUK.
#8 Updated by kytv 2015-10-29 03:44:18
- Status changed from Confirmed to In Progress
- Assignee changed from kytv to anonym
- % Done changed from 0 to 50
- QA Check set to Ready for QA
- Feature Branch set to kytv/bugfix/10428-disable-addon-updates-in-icedove
#9 Updated by anonym 2015-10-30 05:27:22
- Status changed from In Progress to Fix committed
- % Done changed from 50 to 100
Applied in changeset commit:41866057a8ba42aa9f8c68002a2324e27bcd5a80.
#10 Updated by anonym 2015-10-30 07:19:39
- Assignee deleted (
anonym) - QA Check changed from Ready for QA to Pass
#11 Updated by anonym 2015-11-03 11:28:37
- Status changed from Fix committed to Resolved