Feature #10383
Pidgin cannot be given options (like -d)
100%
Description
reported by user (coding plugin for pidgin), confirmed by me.
Because of our wrapper for pidgin, command line options like -d cannot be used.
This could be fixed with provided patch, but I cannot really decide if allowing options for pidgin could have unwanted consequences. I have tested that changing /usr/local/bin/pidgin works, though, and I can run pidgin with options. I have not made a new image.
Please review the security implications.
Files
Subtasks
History
#1 Updated by emmapeel 2015-10-17 03:54:00
- Description updated
#2 Updated by intrigeri 2015-10-23 07:37:10
- Status changed from Confirmed to In Progress
- Assignee set to emmapeel
- Priority changed from Normal to Low
- Type of work changed from Discuss to Code
> This could be fixed with provided patch,
Yes :) It lacks quoting, though: look at our other wrappers for examples of how to do it safely.
> but I cannot really decide if allowing options for pidgin could have unwanted consequences.
One can do it by hand anyway, so forwarding the options via the wrapper is harmless in itself.
#3 Updated by emmapeel 2015-12-26 04:58:32
- Assignee deleted (
emmapeel) - QA Check changed from Dev Needed to Ready for QA
- Feature Branch set to emmapeel: feature/10383-Options_for_Pidgin
- Starter set to Yes
Ok, did the quoting with the electrum and icedove wrappers as example.
Please review topic branch in my repo:
https://git-tails.immerda.ch/emmapeel/tails/diff/?h=feature/10383-Options_for_Pidgin
#4 Updated by intrigeri 2015-12-31 07:14:30
- Assignee set to anonym
- Target version set to Tails_2.0
#5 Updated by anonym 2016-01-03 13:47:19
- Status changed from In Progress to Fix committed
- % Done changed from 0 to 100
Applied in changeset commit:75675e0a9bfb7d859fb2ff1fd41e23b2216d5bd5.
#6 Updated by anonym 2016-01-03 13:49:05
- Assignee deleted (
anonym)
The
"{$@}"
part is incorrect, and should be
"${@}"
so I took the liberty of fixing up your commit before merging, emma. :)
#7 Updated by anonym 2016-01-03 13:57:19
- QA Check changed from Ready for QA to Pass
#8 Updated by anonym 2016-01-27 13:33:47
- Status changed from Fix committed to Resolved