Bug #10327

Verify and correct eventual encoding bugs in Tails installer

Added by Anonymous 2015-10-02 15:09:34 . Updated 2015-11-10 12:16:49 .

Status:
Resolved
Priority:
High
Assignee:
Category:
Installation
Target version:
Start date:
2015-10-02
Due date:
% Done:

70%

Feature Branch:
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Installer
Deliverable for:

Description

https://labs.riseup.net/code/issues/8556#note-22:

some encoding bugs occured only when run in some non-English locales, when some external process failed and output non-ascii chars in its error message. It’s probably a blocker for uploading to sid, but maybe not for uploading to experimental first.


Subtasks


Related issues

Blocks Tails - Feature #8557: Have Tails Installer uploaded and accepted into Debian Resolved 2015-01-06

History

#1 Updated by Anonymous 2015-10-02 15:10:44

#2 Updated by intrigeri 2015-10-02 15:24:29

  • blocks #8538 added

#3 Updated by intrigeri 2015-10-02 15:26:24

  • Category set to Installation

#4 Updated by intrigeri 2015-10-02 15:27:32

#5 Updated by intrigeri 2015-10-02 15:27:47

  • blocks Feature #8556: Make Tails Installer work fine outside of Tails added

#6 Updated by Anonymous 2015-10-02 17:18:03

Could not reproduce the bug for now. Tested only using the “normal” installation way.

#7 Updated by intrigeri 2015-10-02 17:20:08

  • blocked by deleted (Feature #8556: Make Tails Installer work fine outside of Tails)

#8 Updated by intrigeri 2015-10-02 17:21:20

  • blocks Feature #8557: Have Tails Installer uploaded and accepted into Debian added

#9 Updated by Anonymous 2015-10-27 07:32:42

  • Target version changed from Tails_1.7 to Tails_1.8

I am postponing this. Until now I have not seen those errors again.

#10 Updated by intrigeri 2015-10-31 08:09:22

> Target version changed from Tails_1.7 to Tails_1.8

> I am postponing this.

Formally speaking, this is blocking Feature #8557 that is scheduled for 1.7 (and should really happen ASAP in practice), so I’m afraid that there’s some planning inconsistency here. But perhaps this should not be blocking Feature #8557.

> Until now I have not seen those errors again.

My understanding of the current situation is:

  • we know there was a bug back in July, you’ve seen it a few times (but apparently we didn’t capture the debugging info anywhere back then, did we?);
  • the chances that we’ve unconsciously fixed that bug already are extremely low, so most likely the bug will happen in the real world; OTOH I doubt we’ve introduced that bug in feature/jessie, so it’s likely has been in Tails forever, and in this case this should not be blocking Feature #8557 (and is not really a problem or I formally committed to work on);
  • we know the bug only happens in some failure mode situations; we have a quite good understanding of what kind of situations they are (see the ticket description);
  • you didn’t manage to set up the needed environment for reproducing it yet.

Is this a fair assessment?

If yes, then I think we need to re-evaluate whether this is a blocker for uploading to Debian. I can perhaps help do this by trying to set up what’s needed to reproduce the bug (it seemed to me, at some point, that I had a clearer understanding than you of how exactly one could trigger the bug). Once I’ve done this we can evaluate how grave the problem is and reconsider its blocking status.

What do you think?

#11 Updated by Anonymous 2015-11-02 11:43:13

intrigeri wrote:
> > Target version changed from Tails_1.7 to Tails_1.8
>
> > I am postponing this.
>
> Formally speaking, this is blocking Feature #8557 that is scheduled for 1.7 (and should really happen ASAP in practice), so I’m afraid that there’s some planning inconsistency here. But perhaps this should not be blocking Feature #8557.

thanks for the clarification which i was not aware of.

> > Until now I have not seen those errors again.
>
> My understanding of the current situation is:
>
> * we know there was a bug back in July, you’ve seen it a few times (but apparently we didn’t capture the debugging info anywhere back then, did we?);
> * the chances that we’ve unconsciously fixed that bug already are extremely low, so most likely the bug will happen in the real world; OTOH I doubt we’ve introduced that bug in feature/jessie, so it’s likely has been in Tails forever, and in this case this should not be blocking Feature #8557 (and is not really a problem or I formally committed to work on);
> * we know the bug only happens in some failure mode situations; we have a quite good understanding of what kind of situations they are (see the ticket description);
> * you didn’t manage to set up the needed environment for reproducing it yet.
>
> Is this a fair assessment?
>
> If yes, then I think we need to re-evaluate whether this is a blocker for uploading to Debian. I can perhaps help do this by trying to set up what’s needed to reproduce the bug (it seemed to me, at some point, that I had a clearer understanding than you of how exactly one could trigger the bug). Once I’ve done this we can evaluate how grave the problem is and reconsider its blocking status.
>
> What do you think?

Ack. Yes, I’d be grateful if you could help set up what’s needed to reproduce the bug.
As indeed, I only remember that it was related to non-english locales, but that’s about it. Not when it was triggered.

#12 Updated by intrigeri 2015-11-04 02:30:49

  • Assignee set to intrigeri

> Ack. Yes, I’d be grateful if you could help set up what’s needed to reproduce the bug.

Will (try to) do.

> As indeed, I only remember that it was related to non-english locales, but that’s about it. Not when it was triggered.

The ticket description reads: “when some external process failed and output non-ascii chars in its error message”.

#13 Updated by intrigeri 2015-11-05 11:22:19

  • Priority changed from Normal to High

This is blocking something that is now high prio.

#14 Updated by intrigeri 2015-11-10 06:52:24

Note to myself: look for all remaining instances of subprocess.Popen.

#15 Updated by intrigeri 2015-11-10 07:19:38

Note to myself: try reproducing with self.popen too.

#16 Updated by intrigeri 2015-11-10 08:06:34

  • Status changed from Confirmed to In Progress
  • Assignee deleted (intrigeri)
  • % Done changed from 0 to 70

I’ve fixed one such bug (049a7f748a4c760d8e3a1c9833330406d3fe2e88) and did not manage to trigger similar ones with self.popen (replacing various calls to sgdisk and syslinux with calls to a wrapper that prints UTF-8 to stdout + stderr, and exits with nno-zero). So at least the bug we had analyzed in July seems to be limited to 7z, unless we analyzed it wrongly.

u, please close after we have a new upstream release + updated package with this fix in.

#17 Updated by Anonymous 2015-11-10 12:16:50

  • Status changed from In Progress to Resolved

I’ve pushed a new upstream release and package.