Feature #10313

Assistant: Write "Mac command line" scenario

Added by sajolida 2015-09-30 09:53:36 . Updated 2015-10-30 02:35:05 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Installation
Target version:
Start date:
2015-09-30
Due date:
% Done:

0%

Feature Branch:
web/10313-mac-usb
Type of work:
End-user documentation
Blueprint:

Starter:
Affected tool:
Installation Assistant
Deliverable for:

Description


Subtasks


History

#1 Updated by sajolida 2015-09-30 09:53:45

#2 Updated by sajolida 2015-10-13 10:10:43

  • Status changed from Confirmed to In Progress

Started by writing the replacement of /doc/first_steps/installation/manual/mac.

#3 Updated by sajolida 2015-10-22 10:18:58

I’m alsmost there. I’m missing some feedback from frontdesk and from SpencerOne.

#4 Updated by sajolida 2015-10-26 09:26:14

  • Assignee changed from sajolida to tchou
  • QA Check set to Ready for QA
  • Feature Branch set to web/10313-mac-usb

Updated the screenshot. I don’t think that the feedback from frontdesk should block us on this as the current instructions should work in all cases. I’ll still ping them and be happy if they provide more insight.

So this is finally Ready for QA. Same as always, the faster you review this one the easier for me to work on other branches especially since this one included important changes to the CSS mechanism.

As part of this, you should review with care:

  • 678ebd6 which is the new CSS mechanism.
  • 9bcda2d and a94674d which contradict a decision that we took ealier but I changed my mind and I’m providing good reasons now.
  • 187e48e

This branch was started from web/10310-clone, so you should review web/10310-clone first and if I haven’t merged it yet you can review this one only by doing:

git log -p origin/web/10310-clone...origin/web/10313-mac-usb

#5 Updated by tchou 2015-10-27 04:20:24

  • Assignee changed from tchou to sajolida
  • QA Check deleted (Ready for QA)

I reviewed all.

I’m not shure to understand the “We also have to distinguish between and which are ”inline" and

, , and

which are “block” because the “initial” value of the “display” property is not available on IE.".

- I think are not block but inline-block.
- In Bootstrap, there are “.hidden” and “.show” classes but it forces back to block (
http://getbootstrap.com/css/#helper-classes-show-hide) so it’s not usable. Maybe we could try to use this kind of more generic classes (with .inline-show and .inline-hidden classes). Anyway, as far as the current solution is working in this css/ikiwiki inception, I’m ok. :-) (and mabye this kind of “action” semantic does not make sense here, it’s just to give some css feedbacks.).

#6 Updated by sajolida 2015-10-27 09:53:54

  • Assignee changed from sajolida to tchou
  • QA Check set to Info Needed

Thanks for the review.

* Yes, is ‘inline-block’ by default according to http://www.w3.org/TR/html-markup/img.html. Still, in our case this only applies to images inside the steps (screenshots, infography steps and states) and ‘block’ is working fine right now. So unless you identify an actual problem with ‘block’, I’ll like to keep it like this as it’s proven to work in the work I’ve done, it’ll save me half an hour of not-so-interesting work and it makes our code shorter.

* I had to create different CSS statments for and on the one hand and

and

on the other hand because it’s not possible, through CSS only to have elements going from “display: none” back to their default value in IE (where “display: initial” is not available). So I had to state again what is the initial display value of the elements that I was concerned about (

).

  • I don’t think it’s possible to use more generic classes as what we are doing here is to show and hide elements from the same HTML code depending on the context (the scenario). In other words, we need to find a way of saying “hide this on Mac scenarios”, “show this on Windows scenarios”. I wish ikiwiki allowed us more flexibiliy in terms of code reuse and wouldn’t force us to do tricks like this but I couldn’t find anything else (and it’s not that ugly either).

So please tell me if you see real problems with the current code or if you write a proof-of-concept of some smarter technique and otherwise I’ll merge this.

#7 Updated by tchou 2015-10-27 15:52:32

  • Status changed from In Progress to Resolved
  • Assignee changed from tchou to sajolida
  • QA Check deleted (Info Needed)

> So please tell me if you see real problems with the current code or if you write a proof-of-concept of some smarter technique and otherwise I’ll merge this.

As I said: “as far as the current solution is working in this css/ikiwiki inception, I’m ok. :-)”. It means: I am ok. And after: “it’s just to give some css feedbacks”. I don’t know what to say more.

#8 Updated by sajolida 2015-10-28 08:32:36

  • Assignee deleted (sajolida)

Oops, sorry I misread your comment. Now I understand better. These days I’m always working a bit in a rush so I might miss things like this one.

Now I merged it!

#9 Updated by sajolida 2015-10-30 02:35:05

Frontdesk reported that on Mac that don’t boot Tails, the USB stick still appears in the list of startup disks, then the Tails boot menu appears as well but either gets stuck there or gets a black screen right after. So the current instructions are fine. Yeepee!