Bug #10219

Escape regexp used to match nick in CTCP replies

Added by anonym 2015-09-17 15:18:57 . Updated 2015-11-03 11:29:59 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Test suite
Target version:
Tails_1.7
Start date:
2015-09-17
Due date:
% Done:

100%

Feature Branch:
test/10219-escape-nick-for-ctcp-responses
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:
267

Description

Look at this from the CTCP helper:

    if m.ctcp? and /^:#{@spam_target}!/.match(m)


Our Pidgin nick’s have a 10% chance to include a ^, which will break that regexp. We need to escape all characters in the nickname.

Subtasks

History

#1 Updated by anonym 2015-09-17 15:19:14

#2 Updated by anonym 2015-09-17 15:27:46

  • Status changed from Confirmed to In Progress

Applied in changeset commit:87822647539a510c221700d708671b7c6a0aff92.

#3 Updated by anonym 2015-09-17 15:28:40

  • Assignee changed from anonym to kytv
  • % Done changed from 0 to 50
  • QA Check set to Ready for QA
  • Feature Branch set to test/10219-escape-nick-for-ctcp-responses

#4 Updated by kytv 2015-09-18 14:25:13

Code looks good (and necessary) but still doing the obligatory testing.

#5 Updated by kytv 2015-09-18 14:45:09

  • Assignee changed from kytv to intrigeri

Testing passed, although I’m not sure how it could have failed. :)

#6 Updated by intrigeri 2015-09-22 01:34:00

  • Target version changed from Tails_1.6 to Tails_1.7

#7 Updated by intrigeri 2015-09-22 02:06:44

  • blocks #8668 added

#8 Updated by intrigeri 2015-09-22 02:07:12

  • Deliverable for set to 267

#10 Updated by intrigeri 2015-09-22 02:08:58

  • Status changed from In Progress to Fix committed
  • % Done changed from 50 to 100

Applied in changeset commit:4fd56700f34b5dd66677f80a83bcc1803ff5bf1c.

#11 Updated by intrigeri 2015-09-22 02:09:47

  • Assignee deleted (intrigeri)
  • QA Check changed from Ready for QA to Pass

#12 Updated by anonym 2015-11-03 11:29:59

  • Status changed from Fix committed to Resolved