Bug #10184

Disable Firefox's suffix and prefix adding in I2P Browser

Added by kytv 2015-09-12 06:52:16 . Updated 2015-09-22 14:42:14 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Target version:
Tails_1.6
Start date:
2015-09-12
Due date:
% Done:

100%

Feature Branch:
kytv:bug/10184-do_not_set_hostname_prefix_or_suffix_in_I2PBrowser
Type of work:
Code
Blueprint:

Starter:
Affected tool:
I2P
Deliverable for:

Description

This feature—while useful on the internet—doesn’t help at all on I2P since all sites end in .i2p.

I’ve not seen the autoguessing happen during normal use on Tails but I have seen it while working on the test suite.

Files

i2p-2015-09-13T20_31_43+00_00.png (133459 B) kytv, 2015-09-13 13:34:05

Subtasks

Related issues

Blocks Tails - Feature #6306: Write tests for I2P Resolved 2013-09-26 2015-07-15

History

#1 Updated by kytv 2015-09-12 06:52:44

#2 Updated by kytv 2015-09-12 07:33:34

  • Assignee changed from kytv to anonym
  • QA Check set to Ready for QA
  • Feature Branch set to kytv:bug/10184-do_not_set_hostname_prefix_or_suffix_in_I2PBrowser

#3 Updated by anonym 2015-09-13 08:26:21

  • Assignee changed from anonym to kytv
  • QA Check changed from Ready for QA to Info Needed

This makes absolute sense and I’d like to merge it.

However, I failed to make the I2P Browser actually do the suffix/prefix adding (without the suggested pref) so I cannot test it, really. I’ve only looked at what’s put into the address bar, not what’s actually asked over the I2P http proxy. Any ideas/pointers?

#4 Updated by kytv 2015-09-13 12:46:33

anonym wrote:
> This makes absolute sense and I’d like to merge it.
>
> However, I failed to make the I2P Browser actually do the suffix/prefix adding (without the suggested pref) so I cannot test it, really. I’ve only looked at what’s put into the address bar, not what’s actually asked over the I2P http proxy. Any ideas/pointers?

Let me see if I can find a way to somewhat reliably reproduce this, even if it means I publish my wip-i2p tests.

It may have only been seen with a newer I2P. To be determined.

#5 Updated by kytv 2015-09-13 13:41:04

kytv wrote:
> anonym wrote:
> > This makes absolute sense and I’d like to merge it.

> Let me see if I can find a way to somewhat reliably reproduce this, even if it means I publish my wip-i2p tests.
>
> It may have only been seen with a newer I2P. To be determined.

Without this branch I can reproduce the problem in my I2P test branch with I2P 0.9.22.

    When I start the I2P Browser through the GNOME menu                                         # features/step_definitions/unsafe_browser.rb:124
    Then the I2P router console is displayed in I2P Browser                                     # features/step_definitions/i2p.rb:25
calling as root: . /usr/local/lib/tails-shell-library/i2p.sh; i2p_has_built_a_tunnel
call returned: [0, "", ""]
    And I2P successfully built a tunnel                                                         # features/step_definitions/i2p.rb:80
calling as root: . /usr/local/lib/tails-shell-library/tor-browser.sh; echo ${TBB_INSTALL}/firefox
call returned: [0, "/usr/local/lib/tor-browser/firefox\n", ""]
[log] CLICK on (369,132)
calling as root: . /usr/local/lib/tails-shell-library/tor-browser.sh; echo ${TBB_INSTALL}/firefox
call returned: [0, "/usr/local/lib/tor-browser/firefox\n", ""]
[log] CLICK on (293,167)
[log] TYPE "http://i2p-projekt.i2p
"
    When I open the address "http://i2p-projekt.i2p" in the I2P Browser                         # features/step_definitions/common_steps.rb:556
calling as amnesia: xdotool search --name 'I2P Browser' windowactivate --sync
call returned: [0, "", ""]
    Then the I2P homepage loads in I2P Browser                                                  # features/step_definitions/i2p.rb:71
      FindFailed: can not find I2PBrowserProjectHomepage.png on the screen.
      Line ?, in File ? (RuntimeError)
      features/i2p.feature:40:in `Then the I2P homepage loads in I2P Browser'
Scenario failed at time 00:04:34find
Took screenshot "/tmp/TailsToaster/i2p-2015-09-13T20:31:43+00:00.png"

Attached is the screenshot that taken when the test failed. The tests are in my test/6306-tests-for-I2P branch.

#6 Updated by anonym 2015-09-14 09:35:38

  • Status changed from In Progress to Fix committed
  • % Done changed from 40 to 100

Applied in changeset commit:beedeb04a2539f1058eb8666d142f552a7348e39.

#7 Updated by anonym 2015-09-14 09:36:29

  • Assignee deleted (anonym)
  • QA Check changed from Ready for QA to Pass

#8 Updated by bertagaz 2015-09-22 14:42:14

  • Status changed from Fix committed to Resolved
  • QA Check deleted (Pass)