Feature #10147

Make omitted --old-iso default to --iso in the automated test suite

Added by anonym 2015-09-02 02:34:04 . Updated 2015-09-22 15:01:54 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Test suite
Target version:
Start date:
2015-09-02
Due date:
% Done:

100%

Feature Branch:
test/10147-default-old-iso
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

Instead of erroring out, let’s just make the old Tails ISO be the same as the ISO being tested when —old-iso is omitted. This will sill results in us testing the most important thing we want to test, i.e. that the Tails Installer works in the ISO being tested.

Then we can also remove the @old_iso tag.


Subtasks


History

#1 Updated by intrigeri 2015-09-02 03:08:06

Great idea! I’ve always wondered why we had that filename check (and I’ve often cheated by simply copying the same ISO under another name, to use it as --old-iso).

#2 Updated by anonym 2015-09-02 09:45:15

  • Status changed from Confirmed to In Progress

Applied in changeset commit:1bfb2dd3c2aabdd27adc35dc40a70aa6f99d3505.

#3 Updated by anonym 2015-09-02 09:46:29

  • Assignee changed from anonym to kytv
  • % Done changed from 0 to 50
  • QA Check set to Ready for QA
  • Feature Branch set to test/10147-default-old-iso

I suppose this whole idea is debatable, so beyond reviewing and testing, please give me your opinions!

#4 Updated by anonym 2015-09-03 02:35:02

intrigeri wrote:
> I’ve always wondered why we had that filename check

Well, it seemed like a reasonable sanity check if we require the —old-iso to an earlier edition. That implies that they cannot be the same. Crappy, I know. :)

> (and I’ve often cheated by simply copying the same ISO under another name, to use it as --old-iso).

Me too (to avoid the above “cleverness”)! :S

#5 Updated by kytv 2015-09-04 17:18:12

  • Assignee changed from kytv to intrigeri

I like this.

Code review passes. Testing with with omitting --old-iso and including it passes.

Would merge. :)

#6 Updated by bertagaz 2015-09-13 07:26:36

  • Status changed from In Progress to Fix committed
  • % Done changed from 50 to 100

Applied in changeset commit:223d17fae6673ed433be9ae590d08335ff76c210.

#7 Updated by bertagaz 2015-09-13 07:29:58

  • Assignee deleted (intrigeri)
  • QA Check changed from Ready for QA to Pass

Looks good! Merged in stable.

#8 Updated by intrigeri 2015-09-14 09:05:30

> Looks good! Merged in stable.

Yay! Added commit:f68ae35 on top (master branch) so that we don’t forget to pass --old-iso at release testing time.

#9 Updated by bertagaz 2015-09-22 15:01:54

  • Status changed from Fix committed to Resolved
  • QA Check deleted (Pass)