Feature #10088

Port lc.py to Python 3

Added by alant 2015-08-24 06:34:04 . Updated 2017-06-28 15:17:17 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Target version:
Start date:
2015-08-24
Due date:
% Done:

100%

Feature Branch:
Type of work:
Code
Blueprint:

Starter:
1
Affected tool:
Deliverable for:

Description

config/chroot_local-includes/usr/local/bin/lc.py should be migrated to python3

To test your changes: start a Tails nightly build from the feature/jessie branch (http://nightly.tails.boum.org/build_Tails_ISO_feature-jessie/), select “More options”, set an admin (sudo) password, apply your changes, and then:

/usr/local/bin/lc.py -g 1 --min 4 --max 10 /usr/share/amnesia/firstnames.txt

It should output a “random” nickname.

Subtasks

History

#1 Updated by alant 2015-08-24 06:34:40

#2 Updated by intrigeri 2015-08-24 23:52:44

  • Subject changed from Migrate lc.py to python3 to Port lc.py to Python 3
  • Status changed from New to Confirmed

#3 Updated by intrigeri 2015-08-26 07:21:43

  • Description updated

#4 Updated by sycamoreone 2016-08-20 03:51:40

  • Assignee set to sycamoreone
  • % Done changed from 0 to 20

#5 Updated by heartsucker 2016-08-20 06:32:23

Hey. First time contributor, so I didn’t assign this to myself, and in the time between starting it and finishing it, someone else jumped on this (after 12 months of inactivity D: ).

I have a patch completed, and hosted here: https://github.com/heartsucker/tails/tree/issue-10088

What is the preferred way to get this merged?

#6 Updated by sycamoreone 2016-08-22 13:00:47

Hi!

> What is the preferred way to get this merged?

See https://tails.boum.org/contribute/how/code/ and in particular https://tails.boum.org/contribute/merge_policy/

If there are general questions about the process you can also write to tails-dev@boum.org.

#7 Updated by sycamoreone 2016-08-22 13:06:44

  • Status changed from Confirmed to In Progress

#8 Updated by intrigeri 2016-08-23 00:09:20

  • QA Check set to Ready for QA

#9 Updated by sycamoreone 2016-08-23 12:52:04

I will review the patch but this will need some time, as this a complete re-write in Python 3. The original lc.py as 137 lines, the unified diff has 248 lines :)

#10 Updated by intrigeri 2017-06-28 15:17:17

  • Status changed from In Progress to Resolved
  • Assignee deleted (sycamoreone)
  • % Done changed from 20 to 100
  • QA Check changed from Ready for QA to Pass

anonym did this in commit:2b2b6c76d10db733905fad978340150da3c920a4. I have no idea if this was based on the patch contributed 10 months ago, but anyone: done!