Bug #10072
Validate input of add-mirror.sh and delete-mirror.sh
Start date:
2015-08-21
Due date:
% Done:
100%
Description
Subtasks
History
#1 Updated by sajolida 2015-08-21 09:59:15
- Assignee changed from sajolida to intrigeri
- QA Check set to Ready for QA
- Feature Branch set to 10072-validate-input
That’s minimal but should prevent big mistakes.
#2 Updated by intrigeri 2015-08-23 23:27:11
- Status changed from Confirmed to Resolved
- Assignee deleted (
intrigeri) - % Done changed from 0 to 100
- QA Check changed from Ready for QA to Pass
I’d prefer set -u
(that can still be added, btw) but that’s fine. Merged!
#3 Updated by sajolida 2015-08-25 09:49:35
- Assignee set to sajolida
- QA Check changed from Pass to Dev Needed
I didn’t know about “set -u”. I’ll do that too as part of the same ticket. The previous commits add usage documentation which is good anyway.
#4 Updated by intrigeri 2015-08-25 11:04:38
- Status changed from Resolved to In Progress
#5 Updated by sajolida 2015-08-28 07:38:45
- Assignee changed from sajolida to intrigeri
- QA Check changed from Dev Needed to Ready for QA
Done in 89960f3. Please have a look.
#6 Updated by intrigeri 2015-08-29 03:15:12
- Status changed from In Progress to Resolved
- Assignee deleted (
intrigeri) - QA Check changed from Ready for QA to Pass
Good, merged, thanks! Added two robustness commits on top.